From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [RFC][PATCH 04/13] tools/libxl: detect and avoid conflicts with RDM Date: Fri, 8 May 2015 16:13:42 +0100 Message-ID: <20150508151342.GP3848@zion.uk.xensource.com> References: <1428657724-3498-1-git-send-email-tiejun.chen@intel.com> <1428657724-3498-5-git-send-email-tiejun.chen@intel.com> <5534FB700200007800073B6C@mail.emea.novell.com> <554A2CA1.9030907@intel.com> <554A509402000078000773F6@mail.emea.novell.com> <554ACC5C.2040300@intel.com> <554C1068.7020500@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <554C1068.7020500@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Chen, Tiejun" Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich , yang.z.zhang@intel.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, May 08, 2015 at 09:24:56AM +0800, Chen, Tiejun wrote: > Campbell, Jackson, Wei and Stefano, > > Any consideration? > > I can follow up Jan's idea but I need you guys make sure I'm going to do > this properly. > Look at my earlier reply. 1. This function seems to have bug. 2. Caller should have allocated enough memory so that this function don't have to. Looks like we don't need it, at least not in its current form. Wei.