All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Baozi <cbz@baozis.org>
To: Julien Grall <julien.grall@citrix.com>
Cc: julien.grall@linaro.org, ian.campbell@citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm64: Avoid sending SGI when kicking secondary cpus with spin_table
Date: Sat, 9 May 2015 20:52:56 +0800	[thread overview]
Message-ID: <20150509125255.GA11093@cbz-thinkpad> (raw)
In-Reply-To: <554CE697.1070605@citrix.com>

Hi Julien,

On Fri, May 08, 2015 at 05:38:47PM +0100, Julien Grall wrote:
> Hi Chen,
> 
> On 07/04/15 08:33, Chen Baozi wrote:
> > From: Chen Baozi <baozich@gmail.com>
> > 
> > On arm64, either firmware or xen's smp_up_cpu gate uses WFE on secondary
> > cpus to stand-by when booting. Thus, using SEV is enough for the boot
> > cpu to kick other secondaries. Further more, the current implementation
> > of cpu_up_send_sgi would pass a NULL cpumask pointer to send_SGI, which
> > then lead a data fault on GICv3 send_SGI implementation.
> 
> I've sent a patch to fix send_SGI on GICv3 [1]. You should not see the
> segfault anymore.

Yes, I have. And sorry for not being able to test&reply it in time. I was
busy for other stuffs last few weeks. I'll try the patch as soon as possible.

> 
> Although, you were saying that the SGI is not necessary for the spin
> table. Right?

Yes. I have checked the firmware, linux and xen. They all use WFE on secondary
CPUs to stand-by when booting.

Cheers,

Baozi.

  reply	other threads:[~2015-05-09 12:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  7:33 [PATCH] xen/arm64: Avoid sending SGI when kicking secondary cpus with spin_table Chen Baozi
2015-04-08 12:23 ` Julien Grall
2015-04-15 14:57   ` Ian Campbell
2015-04-15 15:56     ` Julien Grall
2015-04-15 16:21       ` Ian Campbell
2015-04-15 17:53         ` Julien Grall
2015-04-15 17:54         ` Julien Grall
2015-05-08 16:38 ` Julien Grall
2015-05-09 12:52   ` Chen Baozi [this message]
2015-05-08 16:39 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150509125255.GA11093@cbz-thinkpad \
    --to=cbz@baozis.org \
    --cc=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.