All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Liang, Kan" <kan.liang@intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Stephane Eranian <eranian@google.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Vince Weaver <vincent.weaver@maine.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	Sonny Rao <sonnyrao@chromium.org>
Subject: Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization
Date: Mon, 11 May 2015 12:00:30 +0200	[thread overview]
Message-ID: <20150511100030.GA15166@gmail.com> (raw)
In-Reply-To: <20150428105243.GV23123@twins.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Apr 27, 2015 at 03:43:32AM +0000, Liang, Kan wrote:
> > 
> > >
> > > > This leads me to believe that this patch:
> > > >
> > > > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc
> > > > Author: Kan Liang <kan.liang@intel.com>
> > > > Date:   Tue Jan 20 04:54:25 2015 +0000
> > > >
> > > >     perf/x86/intel/uncore: Move uncore_box_init() out of driver
> > > initialization
> > > >
> > > > If I revert it, I bet things will work again.
> > >
> > > Yes the initialization needs to be moved out of the IPI context.
> 
> I'm for the clean revert I think. Crashing is bad, but hiding/delaying
> it seems counter productive too, it'll just mean we'll only learn about
> it later.

So should I revert c05199e5a57a, with a Cc: stable?

Thanks,

	Ingo

  reply	other threads:[~2015-05-11 10:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23  5:47 [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization Stephane Eranian
2015-04-24 13:38 ` Vince Weaver
2015-04-24 14:03   ` Vince Weaver
2015-04-24 14:38     ` Stephane Eranian
2015-04-24 19:22       ` Bjorn Helgaas
2015-04-24 19:29         ` Stephane Eranian
2015-04-25  4:38           ` Andi Kleen
2015-04-27  3:43             ` Liang, Kan
2015-04-28  6:23               ` Stephane Eranian
2015-04-28 10:52               ` Peter Zijlstra
2015-05-11 10:00                 ` Ingo Molnar [this message]
2015-06-08 17:45                   ` Vince Weaver
2015-06-09  7:20                     ` Ingo Molnar
2015-06-09  8:33                   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511100030.GA15166@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=eranian@google.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=sonnyrao@chromium.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.