From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753865AbbEKLbQ (ORCPT ); Mon, 11 May 2015 07:31:16 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32486 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112AbbEKLbO (ORCPT ); Mon, 11 May 2015 07:31:14 -0400 Date: Mon, 11 May 2015 14:31:02 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: remove unused variable Message-ID: <20150511113102.GK14154@mwanda> References: <1431341230-29639-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431341230-29639-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: > there variables were not used anywhere and was showing as build warning. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/lustre/lustre/lov/lov_request.c | 4 +--- > drivers/staging/lustre/lustre/obdclass/acl.c | 1 - > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c b/drivers/staging/lustre/lustre/lov/lov_request.c > index f6e1314..d24ba8e 100644 > --- a/drivers/staging/lustre/lustre/lov/lov_request.c > +++ b/drivers/staging/lustre/lustre/lov/lov_request.c > @@ -74,10 +74,8 @@ void lov_finish_set(struct lov_request_set *set) > kfree(req); > } > > - if (set->set_pga) { > - int len = set->set_oabufs * sizeof(*set->set_pga); > + if (set->set_pga) > OBD_FREE_LARGE(set->set_pga, len); ^^^ It's used right here? regards, dan carpenter