From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbbELHEx (ORCPT ); Tue, 12 May 2015 03:04:53 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:32789 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbbELHEu (ORCPT ); Tue, 12 May 2015 03:04:50 -0400 Date: Tue, 12 May 2015 12:34:44 +0530 From: Viresh Kumar To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Kukjin Kim , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/7] drivers/cpufreq: Convert non-modular drivers to use builtin_driver_register Message-ID: <20150512070444.GE32300@linux> References: <1431287385-1526-1-git-send-email-paul.gortmaker@windriver.com> <1431287385-1526-5-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431287385-1526-5-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10-05-15, 15:49, Paul Gortmaker wrote: > These files depend on Kconfig options all of which are a bool, so > we use the appropriate registration function, which avoids us > relying on an implicit inclusion of which we are > doing currently. > > While this currently works, we really don't want to be including > the module.h header in non-modular code, which we'd be forced > to do, pending some upcoming code relocation from init.h into > module.h. So we fix it now by using the non-modular equivalent. > > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: Kukjin Kim > Cc: linux-pm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker > --- > drivers/cpufreq/exynos-cpufreq.c | 2 +- Exynos can be compiled as a module: drivers/cpufreq/Kconfig.arm: config ARM_EXYNOS_CPUFREQ tristate "SAMSUNG EXYNOS CPUfreq Driver" depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250 -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Tue, 12 May 2015 12:34:44 +0530 Subject: [PATCH 4/7] drivers/cpufreq: Convert non-modular drivers to use builtin_driver_register In-Reply-To: <1431287385-1526-5-git-send-email-paul.gortmaker@windriver.com> References: <1431287385-1526-1-git-send-email-paul.gortmaker@windriver.com> <1431287385-1526-5-git-send-email-paul.gortmaker@windriver.com> Message-ID: <20150512070444.GE32300@linux> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10-05-15, 15:49, Paul Gortmaker wrote: > These files depend on Kconfig options all of which are a bool, so > we use the appropriate registration function, which avoids us > relying on an implicit inclusion of which we are > doing currently. > > While this currently works, we really don't want to be including > the module.h header in non-modular code, which we'd be forced > to do, pending some upcoming code relocation from init.h into > module.h. So we fix it now by using the non-modular equivalent. > > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: Kukjin Kim > Cc: linux-pm at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > Signed-off-by: Paul Gortmaker > --- > drivers/cpufreq/exynos-cpufreq.c | 2 +- Exynos can be compiled as a module: drivers/cpufreq/Kconfig.arm: config ARM_EXYNOS_CPUFREQ tristate "SAMSUNG EXYNOS CPUfreq Driver" depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250 -- viresh