From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932828AbbELUyz (ORCPT ); Tue, 12 May 2015 16:54:55 -0400 Received: from smtprelay0014.hostedemail.com ([216.40.44.14]:55816 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753828AbbELUyu (ORCPT ); Tue, 12 May 2015 16:54:50 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2741:3138:3139:3140:3141:3142:3353:3622:3865:3867:3870:3871:3872:3873:3874:4250:5007:6119:6261:7875:7903:7904:7974:8660:10004:10400:10848:10967:11026:11232:11658:11914:12043:12114:12438:12517:12519:12663:12740:13069:13148:13161:13229:13230:13255:13311:13357:14096:14097:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: jump96_cc2462c4bb3a X-Filterd-Recvd-Size: 2657 Date: Tue, 12 May 2015 16:54:46 -0400 From: Steven Rostedt To: Andrew Morton Cc: Shreyas B Prabhu , linux-kernel@vger.kernel.org, mingo@redhat.com, aneesh.kumar@linux.vnet.ibm.com, paulmck@linux.vnet.ibm.com, preeti@linux.vnet.ibm.com, mgorman@suse.de, namhyung@kernel.org, lizf@cn.fujitsu.com, acme@redhat.com Subject: Re: [PATCH RESEND 0/3] tracing/mm: Fix suspicious rcu_dereference_check() usage warnings Message-ID: <20150512165446.6daf5a4a@gandalf.local.home> In-Reply-To: <20150512133601.2f619efe74d08ed9281667d1@linux-foundation.org> References: <1431105646-26558-1-git-send-email-shreyas@linux.vnet.ibm.com> <5551ABD6.9050007@linux.vnet.ibm.com> <20150512160351.4b5d5606@gandalf.local.home> <20150512133601.2f619efe74d08ed9281667d1@linux-foundation.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 May 2015 13:36:01 -0700 Andrew Morton wrote: > On Tue, 12 May 2015 16:03:51 -0400 Steven Rostedt wrote: > > > On Tue, 12 May 2015 12:59:26 +0530 > > Shreyas B Prabhu wrote: > > > > > Hi Steven, > > > On closer look, there is no particular maintainer who picks changes to > > > this file. Can you please pick these up? > > > > Perhaps Andrew Morton? > > > > No problem, I can take these too. > > > > I grabbed them, thanks. > > > + TP_CONDITION(cpu_online(smp_processor_id())), > > Are we sure these can't generate check_preemption_disabled() warnings? > Is there some reason why all these calls always occur with preemption > disabled? Good catch. I don't think the code does. Now, I'm not sure if we should just add a raw_smp_processor_id(). The idea is just to make sure that the CPU we are running on is online, because it is possible to call theses trace points when the CPU is going offline. If that happens, then there's a race with RCU. Since a task can not be migrated to an offline CPU, we don't need to worry about the cpu_online(smp_processor_id()) returning a false positive. A false negative would just skip a tracepoint, but I'm not sure that is possible either. In any case, comments should also be added to why the condition is there. -- Steve