All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Gospodarek <gospo@cumulusnetworks.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
	davem@davemloft.net, netdev@vger.kernel.org,
	j.vosburgh@gmail.com, vfalico@gmail.com
Subject: Re: [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface
Date: Wed, 13 May 2015 10:43:08 -0400	[thread overview]
Message-ID: <20150513144305.GF9559@gospo.home.greyhouse.net> (raw)
In-Reply-To: <55533D01.6070207@6wind.com>

On Wed, May 13, 2015 at 02:01:05PM +0200, Nicolas Dichtel wrote:
> Le 12/05/2015 19:12, Andy Gospodarek a écrit :
> >On Tue, May 12, 2015 at 05:58:42PM +0200, Jiri Pirko wrote:
> >>Tue, May 12, 2015 at 05:17:45PM CEST, nicolas.dichtel@6wind.com wrote:
> [snip]
> >>>First, nobody seems to care about NETDEV_CHANGEINFODATA (commit
> >>>d4261e565000 says that it was put only to notify userspace). Hence, we can
> >>>call directly rtmsg_ifinfo().
> >>
> >>Please leave this notifier here. Will be needed in very near future for
> >>LAG offloading purposes.
> >
> >I agree with this.  It is extremely useful for a variety of reasons (not
> >just the offload case), so please to do not remove it.
> No problem, I will keep it.
> 
> For my knowledge, can you explain these "variety of reasons"?

I maybe 'variety' was too strong of a word.  :)

The offload case has uses for it in the future as well as the case where
userspace deamons who are not sending the netlink message but are
monitoring netlink messages as a way to track port status.  Deamons that
would help broker multi-host LAGs are one such example.  

Though it does look like the only event that will happen when
NETDEV_CHANGEINFODATA is called is an RTM_NEWLINK, it will get used more
in the future, so please keep it.

      reply	other threads:[~2015-05-13 14:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 14:25 [PATCH net] rtnl: don't send rtnl msg for unregistered iface Nicolas Dichtel
2015-05-11 15:37 ` Jiri Pirko
2015-05-11 16:04   ` Nicolas Dichtel
2015-05-11 16:15     ` Nicolas Dichtel
2015-05-11 17:53       ` Jiri Pirko
2015-05-11 22:15         ` Andy Gospodarek
2015-05-12  8:43         ` Nicolas Dichtel
2015-05-12 15:03         ` [PATCH net v2] rtnl/bond: " Nicolas Dichtel
2015-05-12 15:06           ` Nicolas Dichtel
2015-05-12 15:17             ` [PATCH net v3] " Nicolas Dichtel
2015-05-12 15:58               ` Jiri Pirko
2015-05-12 16:10                 ` Nicolas Dichtel
2015-05-12 16:14                   ` Jiri Pirko
2015-05-13 12:19                     ` [PATCH net v4] " Nicolas Dichtel
2015-05-13 12:24                       ` Jiri Pirko
2015-05-13 12:36                         ` Nicolas Dichtel
2015-05-18  2:44                       ` David Miller
2015-07-13 14:11                       ` Kristian Evensen
2015-07-15 15:07                         ` Nicolas Dichtel
2015-07-16  9:06                         ` Nicolas Dichtel
2015-07-16  9:31                           ` [PATCH linux-3.18.y] rtnl: restore notifications for deleted interfaces Nicolas Dichtel
2015-05-12 17:12                 ` [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface Andy Gospodarek
2015-05-13 12:01                   ` Nicolas Dichtel
2015-05-13 14:43                     ` Andy Gospodarek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150513144305.GF9559@gospo.home.greyhouse.net \
    --to=gospo@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=j.vosburgh@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.