Re: [PATCH] fstests: be compatible with older mkfs.xfs which has no v5 support

[Eryu Guan <eguan@redhat.com>]

On Thu, May 14, 2015 at 08:24:11PM +1000, Dave Chinner wrote:
> On Thu, May 14, 2015 at 12:40:31PM +0800, Eryu Guan wrote:
> > On Thu, May 14, 2015 at 12:14:06PM +1000, Dave Chinner wrote:
> > > On Sun, May 10, 2015 at 07:50:43PM +0800, Eryu Guan wrote:
> > > > With the change to CRCs by default, some tests are updated to call mkfs
> > > > with "-m crc=0" option directly, and this breaks testings on older
> > > > distros where mkfs.xfs doesn't have crc support.
> > > > 
> > > > Introduce a new variable to tell if mkfs.xfs supports v5 xfs and do
> > > > tweaks in _scratch_mkfs_xfs_opts() based on it.
> > > > 
> > > > Signed-off-by: Eryu Guan <eguan@redhat.com>
[snip]
> > > 
> > > Shouldn't this be somewhere in common/config, not in the check
> > > script itself?
> > 
> > When sourcing common/config, SCRATCH_DEV has not been validated, and
> > things get messier when config sections are used.
> 
> Don't need a scratch dev:
> 
> touch /tmp/foo
> mkfs.xfs -N -d file,name=/tmp/foo,size=32m -m crc=0
> rm /tmp/foo

Ah right, thanks, I'll work on v3.

Thanks,
Eryu
> 
> mkfs will succeed if "-m crc=X" is recognised, fail if it isn't.
> the "-N" means it just does arg parsing and checks geometry, etc but
> does not do try to create the filesystem....
> 
> > I missed it, it's better than _scratch_mkfs, thanks! But it's not
> > available in common/config if we want to do the check there.
> 
> *nod*. In which case you'd just use MKFS_XFS_PROG directly, like
> above.
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com