From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YstQj-0006O3-Lg
	for qemu-devel@nongnu.org; Thu, 14 May 2015 09:44:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YstQi-0004ne-QJ
	for qemu-devel@nongnu.org; Thu, 14 May 2015 09:44:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13782)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YstQi-0004kl-Ju
	for qemu-devel@nongnu.org; Thu, 14 May 2015 09:44:04 -0400
Date: Thu, 14 May 2015 21:43:54 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150514134354.GA22867@ad.nay.redhat.com>
References: <1431574469-9605-1-git-send-email-famz@redhat.com>
	<20150514043905.GA11231@ad.nay.redhat.com>
	<55546CB0.8030002@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55546CB0.8030002@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v2 00/13] main-loop: Get rid of
 fd_read_poll and qemu_set_fd_handler2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Giuseppe Lettieri <g.lettieri@iet.unipi.it>, Luigi Rizzo <rizzo@iet.unipi.it>

On Thu, 05/14 11:36, Paolo Bonzini wrote:
> On 14/05/2015 06:39, Fam Zheng wrote:
> > On Thu, 05/14 11:34, Fam Zheng wrote:
> >> Patch 1 adds a stub for qemu_set_fd_handler which will be referenced in coming
> >> patches.
> >>
> >> Patch 2 converts qemu-nbd which compares two global numbers in the fd_read_poll
> >> callback.
> >>
> >> Patches 2~5 converts the four net devices, all of which checks
> >> qemu_can_send_packet() in the callback.
> > 
> > s/2~5/3~6/
> > 
> >>
> >> Patch 6 and 7 finally removes the function.
> > 
> > s/6 and 7/7 and 8/
> 
> Should I queue patches 9-12 now?

Yes if you want to, but I lean to leaving them for now: they are not complete
(making the function return value unchecked) without the return type change in
13.

So let's focus more on 1-8 :)

Fam