From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964796AbbENPMc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 May 2015 11:12:32 -0400
Received: from mail.kernel.org ([198.145.29.136]:40678 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932420AbbENPMb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 May 2015 11:12:31 -0400
Date: Thu, 14 May 2015 12:12:25 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>, Ingo Molnar <mingo@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: make -C tools clean failure on older systems
Message-ID: <20150514151225.GH23588@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

	In:

 -------------
commit 67d8712dcc70aa16d8e14a52eb73870e3cbddfc2
Author: Shuah Khan <shuahkh@osg.samsung.com>
Date:   Wed Mar 18 11:57:39 2015 -0600

    selftests: Fix build failures when invoked from kselftest target

 -------------

You cleaned two variables using different methods, any reason for that?

I asked because the 'undefine' method causes it to fail in older
systems:

[acme@rhel5 linux]$ make -C tools/ clean
<SNIP>
  CLEAN    python
make[1]: Leaving directory `/home/acme/git/linux/tools/perf'
  DESCEND  testing/selftests
make[1]: Entering directory
`/home/acme/git/linux/tools/testing/selftests'
Makefile:30: *** missing separator.  Stop.
make[1]: Leaving directory
`/home/acme/git/linux/tools/testing/selftests'
make: *** [selftests_clean] Error 2
make: Leaving directory `/home/acme/git/linux/tools'

 ----------------------------------

[acme@rhel5 linux]$ make --version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-redhat-linux-gnu
[acme@rhel5 linux]$

Wonder if it would be ok to use:

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 95abddcd7839..f76830643086 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug
 # Makefile to avoid test build failures when test
 # Makefile doesn't have explicit build rules.
 ifeq (1,$(MAKELEVEL))
-undefine LDFLAGS
+override LDFLAGS =
 override MAKEFLAGS =
 endif
 
 ------------------------------------------


- Arnaldo