From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422781AbbENRm3 (ORCPT ); Thu, 14 May 2015 13:42:29 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:36297 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933319AbbENRm1 (ORCPT ); Thu, 14 May 2015 13:42:27 -0400 Date: Thu, 14 May 2015 19:42:22 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: Shuah Khan , Michael Ellerman , David Ahern , Linux Kernel Mailing List Subject: Re: make -C tools clean failure on older systems Message-ID: <20150514174222.GC19338@gmail.com> References: <20150514151225.GH23588@kernel.org> <5554C1BF.7000408@osg.samsung.com> <20150514155453.GI23588@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150514155453.GI23588@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > > > @@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug > > > # Makefile to avoid test build failures when test > > > # Makefile doesn't have explicit build rules. > > > ifeq (1,$(MAKELEVEL)) > > > -undefine LDFLAGS > > > +override LDFLAGS = > > > override MAKEFLAGS = > > > endif > > > > I recall testing with override and remember it to not work. If you would > > bummer, then its not that easy, I thought it was an oversight, but > if you tested it and it didn't work, nevermind, no need, I guess, to > support older systems if it requires more, non trivial, work. So what's the 'make' version cutoff for this capability? We should not require insane hacks, the minimum required make version for the kernel, as per Documentation/Changes, is v3.80: o GNU make 3.80 # make --version Thanks, Ingo