Re: make -C tools clean failure on older systems

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	David Ahern <dsahern@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: make -C tools clean failure on older systems
Date: Thu, 14 May 2015 17:00:32 -0300	[thread overview]
Message-ID: <20150514200032.GC5965@kernel.org> (raw)
In-Reply-To: <20150514174222.GC19338@gmail.com>

Em Thu, May 14, 2015 at 07:42:22PM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > >  # Makefile doesn't have explicit build rules.
> > > >  ifeq (1,$(MAKELEVEL))
> > > > -undefine LDFLAGS
> > > > +override LDFLAGS =
> > > >  override MAKEFLAGS =

> > > I recall testing with override and remember it to not work. If you would

> > bummer, then its not that easy, I thought it was an oversight, but 
> > if you tested it and it didn't work, nevermind, no need, I guess, to 
> > support older systems if it requires more, non trivial, work.

> So what's the 'make' version cutoff for this capability?

> We should not require insane hacks, the minimum required make version 
> for the kernel, as per Documentation/Changes, is v3.80:

>  o  GNU make               3.80                    # make --version

3.81 is what is used where I found the problem.

With his confirmation that one of the two variants that he used on the
same patch to do what seemingly has the same effect for the problem at
hand, the one that is supported in make 3.81 (RHEL5), all is well :-)

- Arnaldo