From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtD0c-0002ez-TO for qemu-devel@nongnu.org; Fri, 15 May 2015 06:38:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtD0Y-0008QG-Th for qemu-devel@nongnu.org; Fri, 15 May 2015 06:38:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtD0Y-0008OP-M3 for qemu-devel@nongnu.org; Fri, 15 May 2015 06:38:22 -0400 Date: Fri, 15 May 2015 16:08:04 +0530 From: Amit Shah Message-ID: <20150515103804.GA15452@grmbl.mre> References: <1429031053-4454-1-git-send-email-dgilbert@redhat.com> <1429031053-4454-4-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429031053-4454-4-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 03/47] qemu_ram_foreach_block: pass up error value, and down the ramblock name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au, yayanghy@cn.fujitsu.com On (Tue) 14 Apr 2015 [18:03:29], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > check the return value of the function it calls and error if it's non-0 > Fixup qemu_rdma_init_one_block that is the only current caller, > and rdma_add_block the only function it calls using it. > > Pass the name of the ramblock to the function; helps in debugging. Reviewed-by: Amit Shah Amit