From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 15 May 2015 13:15:39 +0200 Subject: [U-Boot] [patchv2] socfpga: move configuration options to config file In-Reply-To: References: <20150420123048.GA24149@amd> <20150515084830.GB26883@amd> Message-ID: <201505151315.39574.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, May 15, 2015 at 11:00:37 AM, Masahiro Yamada wrote: > Hi. Hi! > 2015-05-15 17:48 GMT+09:00 Pavel Machek : > > On Fri 2015-05-15 17:36:32, Masahiro Yamada wrote: > >> 2015-05-15 17:31 GMT+09:00 Pavel Machek : > >> > On Tue 2015-04-21 12:23:07, Pavel Machek wrote: > >> >> Setting configuration options in header file leads to incosistency > >> >> between .config user sees, and .config he has. What is worse, a lot > >> >> of compile warnings is presented for any such config option user > >> >> sets in .config. > >> >> > >> >> Signed-off-by: Pavel Machek > >> > > >> > Ping? Please apply. > >> > >> This message was sent to me, but I assume it was addressed to Marek > >> because it is only related to SOCFPGA. > > > > Yes, I'd like Marek to apply it. And Marek wanted your confirmation it > > looks reasonable... > > The defconfig files in u-boot/master have been all cleaned up by > > commit bd328eb38274ffaf04caaa8a6ecc09b7e19a650e > Author: Joe Hershberger > Date: Tue May 12 14:46:24 2015 -0500 > > Clean all defconfigs with savedefconfig > > > > > If this patch is applied onto u-boot-socfpga now and then a pull-req is > issued, it will cause a conflict. > > So, I recommend Marek to sync u-boot-socfpga/master with the mainline, > and then v3 should be applied. Yes Sir, synched! > Please use savedefconfig rather than adding entries to the bottom of the > files. Best regards, Marek Vasut