From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S2992451AbbEOP46 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 May 2015 11:56:58 -0400
Received: from mail-qc0-f178.google.com ([209.85.216.178]:35306 "EHLO
	mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934665AbbEOP45 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 May 2015 11:56:57 -0400
Date: Fri, 15 May 2015 11:56:53 -0400
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, riel@redhat.com, dedekind1@gmail.com,
        linux-kernel@vger.kernel.org, mgorman@suse.de, rostedt@goodmis.org,
        juri.lelli@arm.com, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [RFC][PATCH 1/4] sched: Fix a race between __kthread_bind() and
 sched_setaffinity()
Message-ID: <20150515155653.GA23692@htj.duckdns.org>
References: <20150515154333.712161952@infradead.org>
 <20150515154833.545640346@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150515154833.545640346@infradead.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 15, 2015 at 05:43:34PM +0200, Peter Zijlstra wrote:
> Because sched_setscheduler() checks p->flags & PF_NO_SETAFFINITY
> without locks, a caller might observe an old value and race with the
> set_cpus_allowed_ptr() call from __kthread_bind() and effectively undo
> it.
> 
> 	__kthread_bind()
> 	  do_set_cpus_allowed()
> 						<SYSCALL>
> 						  sched_setaffinity()
> 						    if (p->flags & PF_NO_SETAFFINITIY)
> 						    set_cpus_allowed_ptr()
> 	  p->flags |= PF_NO_SETAFFINITY
> 
> Fix the issue by putting everything under the regular scheduler locks.
> 
> This also closes a hole in the serialization of
> task_struct::{nr_,}cpus_allowed.
> 
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

For workqueue part,

 Acked-by: Tejun Heo <tj@kernel.org>

Please route anyway you see fit.

Thanks.

-- 
tejun