From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: netlink: Disable insertions/removals during rehash Date: Sat, 16 May 2015 17:10:19 -0400 (EDT) Message-ID: <20150516.171019.1206903516753105739.davem@davemloft.net> References: <20150514055824.GB6058@gondor.apana.org.au> <20150515.130257.1322224469755323983.davem@redhat.com> <20150516131628.GA981@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: eric.dumazet@gmail.com, tgraf@suug.ch, netdev@vger.kernel.org To: herbert@gondor.apana.org.au Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:37771 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbbEPVKV (ORCPT ); Sat, 16 May 2015 17:10:21 -0400 In-Reply-To: <20150516131628.GA981@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: From: Herbert Xu Date: Sat, 16 May 2015 21:16:28 +0800 > On Fri, May 15, 2015 at 01:02:57PM -0400, David Miller wrote: >> From: Herbert Xu >> Date: Thu, 14 May 2015 13:58:24 +0800 >> >> > The current rhashtable rehash code is buggy and can't deal with >> > parallel insertions/removals without corrupting the hash table. >> > >> > This patch disables it by partially reverting >> > c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink: eliminate >> > nl_sk_hash_lock"). >> > >> > This patch also removes a bogus socket lock introduced by that >> > very same patch. >> > >> > Signed-off-by: Herbert Xu >> >> Herbert, if you agree with me in the other thread that the lock_sock() >> or something like it has to remain, you'll need to respin this. > > Actually I think this one is OK because I'm replacing it with the > hash table mutex which is just like the previous global lock except > that it is per-family. As you cannot change the family on a netlink > socket this should be good enough. > > But the changelog message is wrong so here is an updated version. > > Cheers, > > ---8<--- > The current rhashtable rehash code is buggy and can't deal with > parallel insertions/removals without corrupting the hash table. > > This patch disables it by partially reverting > c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink: eliminate > nl_sk_hash_lock"). > > Signed-off-by: Herbert Xu Ok, I've queued this up for -stable, thanks Herbert.