From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuHoo-0007vz-6W for qemu-devel@nongnu.org; Mon, 18 May 2015 05:58:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuHok-0003Uq-R8 for qemu-devel@nongnu.org; Mon, 18 May 2015 05:58:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuHok-0003UM-Id for qemu-devel@nongnu.org; Mon, 18 May 2015 05:58:38 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4I9wbnT021806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 18 May 2015 05:58:38 -0400 Date: Mon, 18 May 2015 10:58:34 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150518095834.GC2201@work-vm> References: <1431620920-19710-1-git-send-email-quintela@redhat.com> <1431620920-19710-5-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431620920-19710-5-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > Given a string state, we need a way to get the RunState for that string. > > Signed-off-by: Juan Quintela > --- > include/sysemu/sysemu.h | 1 + > vl.c | 13 +++++++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index c1a403e..e5fff07 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -29,6 +29,7 @@ void runstate_set(RunState new_state); > int runstate_is_running(void); > bool runstate_needs_reset(void); > int runstate_store(char *str, int size); > +RunState runstate_index(char *str); > typedef struct vm_change_state_entry VMChangeStateEntry; > typedef void VMChangeStateHandler(void *opaque, int running, RunState state); > > diff --git a/vl.c b/vl.c > index 7dca13f..ea4319d 100644 > --- a/vl.c > +++ b/vl.c > @@ -620,6 +620,19 @@ int runstate_store(char *str, int size) > return 0; > } > > +RunState runstate_index(char *str) > +{ > + RunState i = 0; > + > + while (i != RUN_STATE_MAX) { > + if (strcmp(str, RunState_lookup[i]) == 0) { > + return i; > + } > + i++; > + } > + return -1; It doesn't seem right to return -1 for the value of an enum (which is otherwise used as an index into an array of strings). Make it return a bool and pass the RunState* as a parameter ? Dave > +} > + > static void runstate_init(void) > { > const RunStateTransition *p; > -- > 2.4.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK