From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753365AbbERNE4 (ORCPT ); Mon, 18 May 2015 09:04:56 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:45113 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbbERNEt (ORCPT ); Mon, 18 May 2015 09:04:49 -0400 Date: Mon, 18 May 2015 18:30:50 +0530 From: Srikar Dronamraju To: Peter Zijlstra Cc: mingo@kernel.org, riel@redhat.com, dedekind1@gmail.com, linux-kernel@vger.kernel.org, mgorman@suse.de, rostedt@goodmis.org, juri.lelli@arm.com Subject: Re: [RFC][PATCH 4/4] sched, numa: Ignore pinned tasks Message-ID: <20150518130050.GA2934@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20150515154333.712161952@infradead.org> <20150515154833.726258767@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150515154833.726258767@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15051813-0021-0000-0000-000005510680 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > static void account_numa_dequeue(struct rq *rq, struct task_struct *p) > { > + if (p->nr_cpus_allowed == 1) { > + rq->nr_pinned_running--; > + WARN_ON_ONCE(p->numa_preferred_nid != -1); > + } > rq->nr_numa_running -= (p->numa_preferred_nid != -1); > rq->nr_preferred_running -= (p->numa_preferred_nid == task_node(p)); > } Shouldnt we reset p->numa_preferred_nid when we are setting the allowed cpus in set_cpus_allowed_common()? Otherwise if an process is set a preferred node based on its numa faults but then is pinned to a different cpu, then we can see this warning.:w! -- Thanks and Regards Srikar Dronamraju