From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YuMCG-00035s-F7
	for qemu-devel@nongnu.org; Mon, 18 May 2015 10:39:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YuMCF-0003iu-Jf
	for qemu-devel@nongnu.org; Mon, 18 May 2015 10:39:12 -0400
Date: Mon, 18 May 2015 16:39:02 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150518143902.GF5999@noname.str.redhat.com>
References: <1431105726-3682-1-git-send-email-kwolf@redhat.com>
	<1431105726-3682-34-git-send-email-kwolf@redhat.com>
	<55564620.2050309@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55564620.2050309@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 33/34] qemu-iotests: Test cache mode option
	inheritance
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org

Am 15.05.2015 um 21:16 hat Max Reitz geschrieben:
> On 08.05.2015 19:22, Kevin Wolf wrote:
> >This is doing a more complete test on setting cache modes both while
> >opening an image (i.e. in a -drive command line) and in reopen
> >situations. It checks that reopen can specify options for child nodes
> >and that cache modes are correctly inherited from parent nodes where
> >they are not specified.
> >
> >Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> >---
> >  tests/qemu-iotests/132     | 336 ++++++++++++++++++++
> >  tests/qemu-iotests/132.out | 767 +++++++++++++++++++++++++++++++++++++++++++++
> >  tests/qemu-iotests/group   |   1 +
> >  3 files changed, 1104 insertions(+)
> >  create mode 100755 tests/qemu-iotests/132
> >  create mode 100644 tests/qemu-iotests/132.out
> 
> 
> So starting from now I once again need to specify -c writethrough
> for running tests in tmpfs... Welp.
> 
> ("Welp" because there is no actual strict requirement to have
> O_DIRECT, because we don't actually use it but only check the
> configuration; so using null-co would be fine, too, but we can only
> use that with raw as the format driver, and raw doesn't support
> backing files...)

Perhaps we should add a switch to tell qemu-iotests to skip test cases
that would require cache.direct=on? Or create a group 'direct' so you
can use '-x direct'?

Kevin