From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuPbY-0006tc-Ej for qemu-devel@nongnu.org; Mon, 18 May 2015 14:17:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuPbU-0001Tt-Ej for qemu-devel@nongnu.org; Mon, 18 May 2015 14:17:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuPbU-0001Tg-A3 for qemu-devel@nongnu.org; Mon, 18 May 2015 14:17:28 -0400 Date: Mon, 18 May 2015 15:17:24 -0300 From: Eduardo Habkost Message-ID: <20150518181724.GC17796@thinpad.lan.raisama.net> References: <1431408986-18323-1-git-send-email-bharata@linux.vnet.ibm.com> <1431408986-18323-2-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431408986-18323-2-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 1/3] cpus: Add Error argument to cpu_exec_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: zhugh.fnst@cn.fujitsu.com, agraf@suse.de, qemu-devel@nongnu.org, imammedo@redhat.com, afaerber@suse.de, david@gibson.dropbear.id.au On Tue, May 12, 2015 at 11:06:24AM +0530, Bharata B Rao wrote: > Add an Error argument to cpu_exec_init() to let users collect the > error. This is in preparation to change the CPU enumeration logic > in cpu_exec_init(). With the new enumeration logic, cpu_exec_init() > can fail if cpu_index values corresponding to max_cpus have already > been handed out. > > Since all current callers of cpu_exec_init() are from instance_init, > use error_abort Error arugment to abort in case of an error. > > Signed-off-by: Bharata B Rao Reviewed-by: Eduardo Habkost -- Eduardo