From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754787AbbERT3c (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 May 2015 15:29:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41770 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754145AbbERT33 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 May 2015 15:29:29 -0400
Date: Mon, 18 May 2015 21:29:03 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <andi@firstfloor.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 11/40] perf tools: Add a test case for thread comm
 handling
Message-ID: <20150518192903.GB12169@krava>
References: <1431909055-21442-1-git-send-email-namhyung@kernel.org>
 <1431909055-21442-12-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431909055-21442-12-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 18, 2015 at 09:30:26AM +0900, Namhyung Kim wrote:

SNIP

> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index f42af98a5c16..372b6395a448 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -171,6 +171,10 @@ static struct test {
>  		.func = test__kmod_path__parse,
>  	},
>  	{
> +		.desc = "Test thread comm handling",
> +		.func = test__thread_comm,
> +	},
> +	{
>  		.func = NULL,
>  	},
>  };
> diff --git a/tools/perf/tests/perf-targz-src-pkg b/tools/perf/tests/perf-targz-src-pkg
> deleted file mode 100755
> index 238aa3927c71..000000000000
> --- a/tools/perf/tests/perf-targz-src-pkg
> +++ /dev/null

you dont like this one? ;-)

jirka

> @@ -1,21 +0,0 @@
> -#!/bin/sh
> -# Test one of the main kernel Makefile targets to generate a perf sources tarball
> -# suitable for build outside the full kernel sources.
> -#
> -# This is to test that the tools/perf/MANIFEST file lists all the files needed to
> -# be in such tarball, which sometimes gets broken when we move files around,
> -# like when we made some files that were in tools/perf/ available to other tools/
> -# codebases by moving it to tools/include/, etc.
> -
> -PERF=$1
> -cd ${PERF}/../..
> -make perf-targz-src-pkg > /dev/null
> -TARBALL=$(ls -rt perf-*.tar.gz)
> -TMP_DEST=$(mktemp -d)
> -tar xf ${TARBALL} -C $TMP_DEST
> -rm -f ${TARBALL}
> -cd - > /dev/null
> -make -C $TMP_DEST/perf*/tools/perf > /dev/null 2>&1
> -RC=$?
> -rm -rf ${TMP_DEST}
> -exit $RC

SNIP