From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932605AbbERTfY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 May 2015 15:35:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52672 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932233AbbERTfW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 May 2015 15:35:22 -0400
Date: Mon, 18 May 2015 21:34:25 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <andi@firstfloor.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 13/40] perf tools: Convert dead thread list into rbtree
Message-ID: <20150518193425.GC12169@krava>
References: <1431909055-21442-1-git-send-email-namhyung@kernel.org>
 <1431909055-21442-14-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431909055-21442-14-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 18, 2015 at 09:30:28AM +0900, Namhyung Kim wrote:

SNIP

> @@ -38,6 +39,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
>  		thread->ppid = -1;
>  		thread->cpu = -1;
>  		INIT_LIST_HEAD(&thread->comm_list);
> +		INIT_LIST_HEAD(&thread->tid_node);
>  
>  		if (unwind__prepare_access(thread) < 0)
>  			goto err_thread;
> @@ -54,7 +56,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
>  
>  		list_add(&comm->list, &thread->comm_list);
>  		atomic_set(&thread->refcnt, 0);
> -		INIT_LIST_HEAD(&thread->node);
> +		INIT_LIST_HEAD(&thread->tid_node);

tid_node is initialized twice

jirka