All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jbaron@akamai.com
Cc: edumazet@google.com, netdev@vger.kernel.org,
	ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH] tcp: ensure epoll edge trigger wakeup when out of memory
Date: Tue, 19 May 2015 00:10:45 -0400 (EDT)	[thread overview]
Message-ID: <20150519.001045.1156234709900758412.davem@davemloft.net> (raw)
In-Reply-To: <20150519.000945.697478668443801629.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Tue, 19 May 2015 00:09:45 -0400 (EDT)

> From: Jason Baron <jbaron@akamai.com>
> Date: Fri, 15 May 2015 21:17:07 +0000 (GMT)
> 
>> From: Jason Baron <jbaron@akamai.com>
>> 
>> If we really can't get an skb allocated, make sure that we let
>> userspace know. This at least gives us a chance to re-try or abort.
>> 
>> Signed-off-by: Jason Baron <jbaron@akamai.com>
> 
> Applied to net-next, thanks Jason.

Nevermind, reverted, you didn't compile let alone test this:

net/ipv4/tcp.c: In function ‘do_tcp_sendpages’:
net/ipv4/tcp.c:1001:34: error: invalid operands to binary == (have ‘struct sk_buff_head’ and ‘int’)
  if (unlikely(sk->sk_write_queue == 0 && err == -EAGAIN))
                                  ^
include/linux/compiler.h:164:42: note: in definition of macro ‘unlikely’
 # define unlikely(x) __builtin_expect(!!(x), 0)
                                          ^
net/ipv4/tcp.c: In function ‘tcp_sendmsg’:
net/ipv4/tcp.c:1292:34: error: invalid operands to binary == (have ‘struct sk_buff_head’ and ‘int’)
  if (unlikely(sk->sk_write_queue == 0 && err == -EAGAIN))
                                  ^
include/linux/compiler.h:164:42: note: in definition of macro ‘unlikely’
 # define unlikely(x) __builtin_expect(!!(x), 0)
                                          ^

  reply	other threads:[~2015-05-19  4:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 21:17 [PATCH] tcp: ensure epoll edge trigger wakeup when out of memory Jason Baron
2015-05-18  2:50 ` Eric Dumazet
2015-05-19  4:09 ` David Miller
2015-05-19  4:10   ` David Miller [this message]
2015-05-19 14:10     ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519.001045.1156234709900758412.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jbaron@akamai.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.