All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: parav.pandit@avagotech.com
Cc: netdev@vger.kernel.org, bwh@kernel.org
Subject: Re: [PATCH] net-next: ethtool: Added port speed macros.
Date: Tue, 19 May 2015 12:32:21 -0400 (EDT)	[thread overview]
Message-ID: <20150519.123221.435329742945502707.davem@davemloft.net> (raw)
In-Reply-To: <CAGgvQNT9M-2u_HWn_mYz1sgX4hceTCnbhr1DctQrAPKPNLKq0g@mail.gmail.com>

From: Parav Pandit <parav.pandit@avagotech.com>
Date: Tue, 19 May 2015 10:15:49 +0530

> On Mon, May 18, 2015 at 9:16 PM, David Miller <davem@davemloft.net> wrote:
>> From: Parav Pandit <parav.pandit@avagotech.com>
>> Date: Mon, 18 May 2015 16:31:47 +0530
>>
>>> Signed-off-by: Parav Pandit <parav.pandit@avagotech.com>
>>
>> I thought we had decided that we weren't going to keep adding
>> convenience macros for new speeds, and were simply going to use
>> the appropriate constants in the future.
>>
> 
> I added them to accommodate any speed/PHY interface specific
> configuration to make use of it.
> If convenience macros are not needed, I will provide the code cleanup
> patch to remove existing convenience macros. With that we will have
> unified code for old and new constants.
> I will anyway let Ben comment on it.

You cannot remove the existing macros, because they are exported to
userspace and you'll break application compilation if you do that.

  reply	other threads:[~2015-05-19 16:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 11:01 [PATCH] net-next: ethtool: Added port speed macros Parav Pandit
2015-05-18 15:46 ` David Miller
2015-05-19  4:45   ` Parav Pandit
2015-05-19 16:32     ` David Miller [this message]
2015-05-19 16:41       ` Parav Pandit
2015-05-19 17:00   ` Ben Hutchings
2015-05-19 18:52     ` David Miller
2015-05-19 20:32       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519.123221.435329742945502707.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bwh@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=parav.pandit@avagotech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.