All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Pedro Marzo Perez <marzo.pedro@gmail.com>
Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com,
	dilekuzulmez@gmail.com, joe@perches.com,
	haticeerturk27@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init
Date: Tue, 19 May 2015 11:04:19 +0530	[thread overview]
Message-ID: <20150519053419.GC3820@sudip-PC> (raw)
In-Reply-To: <1431991944-16924-2-git-send-email-marzo.pedro@gmail.com>

On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.

I would have split this patch into three.
1) introduce pr_fmt and remove "ieee80211_crypt_wep" from pr_debug
2) return NULL instead of that goto fail.
3) combine two pr_debug into a single at the fail block.

But Dan can say if its ok. (I am still taking ideas from Dan about my
patches)

regards
sudip
> 
> Signed-off-by: Pedro Marzo Perez <marzo.pedro@gmail.com>

  reply	other threads:[~2015-05-19  5:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 23:32 [PATCH 0/3 v3] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c Pedro Marzo Perez
2015-05-18 23:32 ` [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init Pedro Marzo Perez
2015-05-19  5:34   ` Sudip Mukherjee [this message]
2015-05-19 22:49     ` pmarzo
2015-05-19 21:46   ` Dan Carpenter
2015-05-20  8:26     ` pmarzo
2015-05-20  9:03       ` Dan Carpenter
2015-05-31  1:36   ` Greg KH
2015-05-18 23:32 ` [PATCH 2/3 v3] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null Pedro Marzo Perez
2015-05-31  1:37   ` Greg KH
2015-05-18 23:32 ` [PATCH 3/3 v3] Staging: rtl8192u: Correct include indentation and openning braces at new line Pedro Marzo Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519053419.GC3820@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dilekuzulmez@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haticeerturk27@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marzo.pedro@gmail.com \
    --cc=navyasri.tech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.