From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754544AbbESGhQ (ORCPT ); Tue, 19 May 2015 02:37:16 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34246 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753244AbbESGhM (ORCPT ); Tue, 19 May 2015 02:37:12 -0400 Date: Mon, 18 May 2015 23:37:09 -0700 From: Christoph Hellwig To: Christoph Hellwig Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: fix queue_lock usage in blk-mq and nvme Message-ID: <20150519063709.GA22313@infradead.org> References: <1430984294-25859-1-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430984294-25859-1-git-send-email-hch@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping? On Thu, May 07, 2015 at 09:38:12AM +0200, Christoph Hellwig wrote: > Historically we always take queue_lock with irqs disabled. Blk-mq doesn't really > use the queue_lock much, but when it does it needs to follow this rules to make > lockdep happy. > > The first patch removes a queue_lock usage instead of fixing things properly, > and the second is a bad-aid for nvme. In the long run I'd prefer to remove > other users of the queue_lock from blk-mq and blk-mq based driver entirely, > but that will require a bit more work. > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme ---end quoted text--- From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Mon, 18 May 2015 23:37:09 -0700 Subject: fix queue_lock usage in blk-mq and nvme In-Reply-To: <1430984294-25859-1-git-send-email-hch@lst.de> References: <1430984294-25859-1-git-send-email-hch@lst.de> Message-ID: <20150519063709.GA22313@infradead.org> ping? On Thu, May 07, 2015@09:38:12AM +0200, Christoph Hellwig wrote: > Historically we always take queue_lock with irqs disabled. Blk-mq doesn't really > use the queue_lock much, but when it does it needs to follow this rules to make > lockdep happy. > > The first patch removes a queue_lock usage instead of fixing things properly, > and the second is a bad-aid for nvme. In the long run I'd prefer to remove > other users of the queue_lock from blk-mq and blk-mq based driver entirely, > but that will require a bit more work. > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme ---end quoted text---