From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YugSG-0006Vv-JI for qemu-devel@nongnu.org; Tue, 19 May 2015 08:17:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YugSC-0003Nv-Q5 for qemu-devel@nongnu.org; Tue, 19 May 2015 08:17:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YugSC-0003NV-Jh for qemu-devel@nongnu.org; Tue, 19 May 2015 08:17:00 -0400 Date: Tue, 19 May 2015 09:14:35 -0300 From: Eduardo Habkost Message-ID: <20150519121435.GF17796@thinpad.lan.raisama.net> References: <1431408986-18323-1-git-send-email-bharata@linux.vnet.ibm.com> <1431408986-18323-3-git-send-email-bharata@linux.vnet.ibm.com> <20150518183654.GD17796@thinpad.lan.raisama.net> <20150519061936.GB31025@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150519061936.GB31025@in.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 2/3] cpus: Convert cpu_index into a bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: zhugh.fnst@cn.fujitsu.com, agraf@suse.de, qemu-devel@nongnu.org, imammedo@redhat.com, afaerber@suse.de, david@gibson.dropbear.id.au On Tue, May 19, 2015 at 11:49:36AM +0530, Bharata B Rao wrote: > On Mon, May 18, 2015 at 03:36:54PM -0300, Eduardo Habkost wrote: > > On Tue, May 12, 2015 at 11:06:25AM +0530, Bharata B Rao wrote: [...] > > > void cpu_exec_init(CPUArchState *env, Error **errp) [...] > > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > > > index 39f0f19..7db310e 100644 > > > --- a/include/qom/cpu.h > > > +++ b/include/qom/cpu.h > > > @@ -672,6 +672,7 @@ void cpu_watchpoint_remove_all(CPUState *cpu, int mask); > > > > > > void QEMU_NORETURN cpu_abort(CPUState *cpu, const char *fmt, ...) > > > GCC_FMT_ATTR(2, 3); > > > +void cpu_exec_exit(CPUState *cpu); > > > > Why don't we keep both cpu_exec_init() and cpu_exec_exit() in the same > > header file? > > Currently cpu_exec_init() is in exec-all.h. > > 1. If I put cpu_exec_exit() also there, qom/cpu.c doesn't like it since > many definitions (like ram_addr_t etc) aren't known in qom/cpu.c. > > 2. I can't move cpu_exec_init() declaration to qom/cpu.h since it results > in the use of poisoned definition of CPUArchState from qom/cpu.c OK, so we can change cpu_exec_init() to use CPUState in a follow-up patch later. Reviewed-by: Eduardo Habkost -- Eduardo