From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuhiQ-0001bD-6x for qemu-devel@nongnu.org; Tue, 19 May 2015 09:37:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuhiL-0008AB-6O for qemu-devel@nongnu.org; Tue, 19 May 2015 09:37:50 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:35423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuhiK-00087w-S3 for qemu-devel@nongnu.org; Tue, 19 May 2015 09:37:45 -0400 Received: by wgfl8 with SMTP id l8so18296662wgf.2 for ; Tue, 19 May 2015 06:37:44 -0700 (PDT) Date: Tue, 19 May 2015 14:37:40 +0100 From: Stefan Hajnoczi Message-ID: <20150519133740.GD9338@stefanha-thinkpad.redhat.com> References: <1431583614-20100-1-git-send-email-sfeldma@gmail.com> <1431583614-20100-2-git-send-email-sfeldma@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Content-Disposition: inline In-Reply-To: <1431583614-20100-2-git-send-email-sfeldma@gmail.com> Subject: Re: [Qemu-devel] [PATCH 1/4] rocker: Add support for phys name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com Cc: jiri@resnulli.us, qemu-devel@nongnu.org, dsahern@gmail.com --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 13, 2015 at 11:06:51PM -0700, sfeldma@gmail.com wrote: > diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c > index 55b6c46..f62fb95 100644 > --- a/hw/net/rocker/rocker.c > +++ b/hw/net/rocker/rocker.c > @@ -15,6 +15,7 @@ > * GNU General Public License for more details. > */ > =20 > +#include This breaks Windows builds: hw/net/rocker/rocker.c:18:20: fatal error: net/if.h: No such file or direct= ory #include ^ On Fedora, check out the mingw64- packages if you a cross toolchain. On other distros you can use http://mxe.cc/ to get a cross toolchain. is POSIX but Windows doesn't seem to have it: http://pubs.opengroup.org/onlinepubs/009696699/basedefs/net/if.h.html Note that IF_NAMESIZE is POSIX and might be more widely available than IFNAMSIZ (BSD). Stefan --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVWzykAAoJEJykq7OBq3PI1NQH/3yc4lk+NMvi2ZnYh+rIlYih +ZqgTbhsWN7gVetssEhkDyrrT+Pzabx0S4Q8oxVjVJqnFsBgzRzmrdvAje4CID3B 8snETtqAQUkhZ452QcZrc2CDijhvp5PgZDJpXOVdYAT6XYY5RKk7umOm+6gXNTJ2 +duvoNPJrneNrSmOa6X11XrD92n63lZ9BbDu9lQ/dCxIiwUsOJq5g8uoXmVeQI7w Sw8kK6n7BNSeTrXBCici2qOCAcZhU/4IAIIsIsmvkcudin4wkc8dYsOy4AwG2GED yKrKtuwp5kzXGhmZ5BSBjm7WXqs5jZkDTtlnWMl+f/lrtnvRNUOPt+kChi9KTJM= =7E5G -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd--