From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuhjV-00038b-Ai for qemu-devel@nongnu.org; Tue, 19 May 2015 09:39:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuhjT-0000ET-MT for qemu-devel@nongnu.org; Tue, 19 May 2015 09:38:57 -0400 Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:35570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuhjT-0000Dr-Go for qemu-devel@nongnu.org; Tue, 19 May 2015 09:38:55 -0400 Received: by wgfl8 with SMTP id l8so18336314wgf.2 for ; Tue, 19 May 2015 06:38:54 -0700 (PDT) Date: Tue, 19 May 2015 14:38:52 +0100 From: Stefan Hajnoczi Message-ID: <20150519133852.GF9338@stefanha-thinkpad.redhat.com> References: <1431583614-20100-1-git-send-email-sfeldma@gmail.com> <1431583614-20100-4-git-send-email-sfeldma@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="udcq9yAoWb9A4FsZ" Content-Disposition: inline In-Reply-To: <1431583614-20100-4-git-send-email-sfeldma@gmail.com> Subject: Re: [Qemu-devel] [PATCH 3/4] rocker: bring link up/down on PHY enable/disable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com Cc: jiri@resnulli.us, qemu-devel@nongnu.org, dsahern@gmail.com --udcq9yAoWb9A4FsZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 13, 2015 at 11:06:53PM -0700, sfeldma@gmail.com wrote: > From: Scott Feldman >=20 > When the OS driver enables/disables the port, go ahead and set the port's > link status to up/down in response to the change. This more closely > emulates real hardware when the PHY for the port is brought up/down > and the PHY negotiates carrier (link status) with link partner. In > the case of qemu, the virtual rocker device can't really do link > negotiation with the link partner as that requires signally over a > physical medium (the wire), so just pretend the negotiation was > successful and bring the link up when the port is enabled. >=20 > Signed-off-by: Scott Feldman > --- > hw/net/rocker/rocker_fp.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Reviewed-by: Stefan Hajnoczi --udcq9yAoWb9A4FsZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVWzzsAAoJEJykq7OBq3PIY4EIAKN+d7lz14jZJaSIuz59lMaS bOi9oPk1WuxL/StRjuTg7cvXvoN8CnNYxn9xYhI/8MdAxmA3XsjpPYtGAO4aOaz9 MsZXJA1Gycgacresr8s4QUHbbZRXcODaSb5amcokaM41QBjKS00Hky9THsXxgRKc smiWH849lV5mpIFIAZEBMvNud446EskNxauimAvfZB9G48EOUzot7iYL0e9BLoYr a2FiWLj9GeLtXW+p4IX3RXS1DwZZgDRDAJqoleXNqU/c+Zd5f5F4zsnGDZeyPrKp 2V2AKhxd/41z6dIyDBjxTvb7fj5qWKedIcBGIExkzvM73rgRZ1eNZJ/GvIuRdTE= =sFJA -----END PGP SIGNATURE----- --udcq9yAoWb9A4FsZ--