From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933280AbbESOS5 (ORCPT ); Tue, 19 May 2015 10:18:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41639 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933074AbbESOR2 (ORCPT ); Tue, 19 May 2015 10:17:28 -0400 Date: Tue, 19 May 2015 07:17:27 -0700 From: Greg Kroah-Hartman To: Douglas Figueiredo Cc: raghav3276@gmail.com, devel@driverdev.osuosl.org, artemiyv@acm.org, tapaswenipathak@gmail.com, matt@ninezulu.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge Message-ID: <20150519141727.GA6578@kroah.com> References: <1432011010-10358-1-git-send-email-eng.douglasfigueiredo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432011010-10358-1-git-send-email-eng.douglasfigueiredo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote: > From: douglasbsf We need a "real" name here, and in the signed-off-by line. Also fix up your subject line like mentioned. > > Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c > > Signed-off-by: douglasbsf > --- > drivers/staging/wlan-ng/prism2fw.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c > index 9408644..27ead4c 100644 > --- a/drivers/staging/wlan-ng/prism2fw.c > +++ b/drivers/staging/wlan-ng/prism2fw.c > @@ -708,7 +708,9 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks, > continue; > } > > - /* Validate plug address against chunk data and identify chunk */ > + /* Validate plug address against > + * chunk data and identify chunk > + */ Please use the correct indentation for multi-line comments as well. Please fix up and resend, I can't take this as-is. greg k-h