From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver Date: Tue, 19 May 2015 15:50:07 +0100 Message-ID: <20150519145006.GH2067@n2100.arm.linux.org.uk> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <555B098A.8030202@linaro.org> <6177628.0ZDPLeVyah@wuerfel> <555B3F80.8070605@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org To: Maxime Coquelin Cc: Daniel Lezcano , Arnd Bergmann , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andreas =?iso-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Joe Perches , Vladimir Zapolskiy , Lee Jones , Daniel Thompson , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell List-Id: linux-gpio@vger.kernel.org On Tue, May 19, 2015 at 04:41:58PM +0200, Maxime Coquelin wrote: > 2015-05-19 15:49 GMT+02:00 Daniel Lezcano : > > > > > > It is not exactly as the initial patch. > > > > I think Arnd is proposing: > > > > config CLKSRC_STM32 > > bool "Clocksource for STM32 SoCs" if COMPILE_TEST > > select CLKSRC_MMIO > > > > Isn't "depends on OF" missing for COMPILE_TEST case? config CLKSRC_STM32 bool "Clocksource for STM32 SoCs" if COMPILE_TEST depends on OF select CLKSRC_MMIO This permits CLKSRC_STM32 to be selected by STM32 (provided OF is enabled, it's always going to be for that case, right?) while allowing the option to be visible when both OF!=n and COMPILE_TEST!=n. Remember, bool "string" if depends on The former merely hides the option from the user _if_ the condition fails. The latter _disables_ the option completely (except if you try and select it, at which point you end up with a Kconfig warning about that.) -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933353AbbESOvD (ORCPT ); Tue, 19 May 2015 10:51:03 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:57280 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933305AbbESOu5 (ORCPT ); Tue, 19 May 2015 10:50:57 -0400 Date: Tue, 19 May 2015 15:50:07 +0100 From: Russell King - ARM Linux To: Maxime Coquelin Cc: Daniel Lezcano , Arnd Bergmann , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andreas =?iso-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Joe Perches , Vladimir Zapolskiy , Lee Jones , Daniel Thompson , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Subject: Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver Message-ID: <20150519145006.GH2067@n2100.arm.linux.org.uk> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <555B098A.8030202@linaro.org> <6177628.0ZDPLeVyah@wuerfel> <555B3F80.8070605@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 04:41:58PM +0200, Maxime Coquelin wrote: > 2015-05-19 15:49 GMT+02:00 Daniel Lezcano : > > > > > > It is not exactly as the initial patch. > > > > I think Arnd is proposing: > > > > config CLKSRC_STM32 > > bool "Clocksource for STM32 SoCs" if COMPILE_TEST > > select CLKSRC_MMIO > > > > Isn't "depends on OF" missing for COMPILE_TEST case? config CLKSRC_STM32 bool "Clocksource for STM32 SoCs" if COMPILE_TEST depends on OF select CLKSRC_MMIO This permits CLKSRC_STM32 to be selected by STM32 (provided OF is enabled, it's always going to be for that case, right?) while allowing the option to be visible when both OF!=n and COMPILE_TEST!=n. Remember, bool "string" if depends on The former merely hides the option from the user _if_ the condition fails. The latter _disables_ the option completely (except if you try and select it, at which point you end up with a Kconfig warning about that.) -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Tue, 19 May 2015 15:50:07 +0100 Subject: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver In-Reply-To: References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <555B098A.8030202@linaro.org> <6177628.0ZDPLeVyah@wuerfel> <555B3F80.8070605@linaro.org> Message-ID: <20150519145006.GH2067@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 19, 2015 at 04:41:58PM +0200, Maxime Coquelin wrote: > 2015-05-19 15:49 GMT+02:00 Daniel Lezcano : > > > > > > It is not exactly as the initial patch. > > > > I think Arnd is proposing: > > > > config CLKSRC_STM32 > > bool "Clocksource for STM32 SoCs" if COMPILE_TEST > > select CLKSRC_MMIO > > > > Isn't "depends on OF" missing for COMPILE_TEST case? config CLKSRC_STM32 bool "Clocksource for STM32 SoCs" if COMPILE_TEST depends on OF select CLKSRC_MMIO This permits CLKSRC_STM32 to be selected by STM32 (provided OF is enabled, it's always going to be for that case, right?) while allowing the option to be visible when both OF!=n and COMPILE_TEST!=n. Remember, bool "string" if depends on The former merely hides the option from the user _if_ the condition fails. The latter _disables_ the option completely (except if you try and select it, at which point you end up with a Kconfig warning about that.) -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.