From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964927AbbESO67 (ORCPT ); Tue, 19 May 2015 10:58:59 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:35480 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932992AbbESO64 (ORCPT ); Tue, 19 May 2015 10:58:56 -0400 Date: Tue, 19 May 2015 09:58:53 -0500 From: Bjorn Helgaas To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Fam Zheng , Yinghai Lu , Yijing Wang , "Eric W. Biederman" , Ulrich Obergfell , Rusty Russell Subject: Re: [PATCH v6 1/2] PCI/MSI: Don't disable MSI/MSI-X at shutdown Message-ID: <20150519145853.GP31666@google.com> References: <1431431730-25164-1-git-send-email-mst@redhat.com> <1431431730-25164-2-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431431730-25164-2-git-send-email-mst@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2015 at 03:03:32PM +0200, Michael S. Tsirkin wrote: > d52877c7b1af ("pci/irq: let pci_device_shutdown to call pci_msi_shutdown > v2") disabled MSI/MSI-X at device shutdown to address a kexec problem. > ... I know you're trying to put all the justification in the changelog, and that's great if it can be done. But would you please just add the single link here to https://bugzilla.kernel.org/show_bug.cgi?id=96571 ? And please attach the dmesg log and instructions for reproducing the problem to the bugzilla. I've asked for this before, and it seems like a simple request, but maybe there's a reason it's more complicated than it seems to me. It's obvious to you how all this fits together, but I'd like it to be more concrete to the rest of us, too. The bugzilla says Ulrich Obergfell noticed this in RHEL7. If there's a RHEL bugzilla, it'd be nice to have a link to it in the kernel.org bugzilla. Informal hints are great right now, but they'll be useless after six months. Bjorn > Reported-by: Fam Zheng > Tested-by: Fam Zheng > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Bjorn Helgaas > CC: Yinghai Lu > CC: Ulrich Obergfell > CC: Rusty Russell > --- > drivers/pci/pci-driver.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > index 3cb2210..38a602c 100644 > --- a/drivers/pci/pci-driver.c > +++ b/drivers/pci/pci-driver.c > @@ -450,8 +450,6 @@ static void pci_device_shutdown(struct device *dev) > > if (drv && drv->shutdown) > drv->shutdown(pci_dev); > - pci_msi_shutdown(pci_dev); > - pci_msix_shutdown(pci_dev); > > #ifdef CONFIG_KEXEC > /* > -- > MST >