From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY Date: Tue, 19 May 2015 17:41:43 -0500 Message-ID: <20150519224143.GS31666@google.com> References: <1430743338-10441-1-git-send-email-svarbanov@mm-sol.com> <1430743338-10441-3-git-send-email-svarbanov@mm-sol.com> <554783CD.50708@ti.com> <55478F1A.3000401@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55478F1A.3000401@mm-sol.com> Sender: linux-pci-owner@vger.kernel.org To: Stanimir Varbanov Cc: Kishon Vijay Abraham I , Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Russell King , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Mathieu Olivari , Srinivas Kandagatla List-Id: linux-arm-msm@vger.kernel.org On Mon, May 04, 2015 at 06:24:10PM +0300, Stanimir Varbanov wrote: > On 05/04/2015 05:35 PM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote: > >> Add a PCIe PHY driver used by PCIe host controller driver > >> on Qualcomm SoCs like Snapdragon 805. > >> > >> Signed-off-by: Stanimir Varbanov > >> --- > >> drivers/phy/Kconfig | 9 ++ > >> drivers/phy/Makefile | 1 + > >> drivers/phy/phy-qcom-pcie.c | 291 > >> +++++++++++++++++++++++++++++++++++++++++++ > > > > Why do you need a new PHY driver for this? Why not use the existing QCOM > > PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h? > > I agree that on first glance there are similarities, but I'm not sure > does the PHYs are the same IP blocks. Or at least they are different > revisions which have too many differences. So trying to combine them > will lead to more code than now. > > Either way I will try to understand how many the differences are. Ping, where are we with this? Should I wait for something else, or are you convinced there's enough difference to warrant a new PHY driver, Kishon? Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: bhelgaas@google.com (Bjorn Helgaas) Date: Tue, 19 May 2015 17:41:43 -0500 Subject: [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY In-Reply-To: <55478F1A.3000401@mm-sol.com> References: <1430743338-10441-1-git-send-email-svarbanov@mm-sol.com> <1430743338-10441-3-git-send-email-svarbanov@mm-sol.com> <554783CD.50708@ti.com> <55478F1A.3000401@mm-sol.com> Message-ID: <20150519224143.GS31666@google.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 04, 2015 at 06:24:10PM +0300, Stanimir Varbanov wrote: > On 05/04/2015 05:35 PM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote: > >> Add a PCIe PHY driver used by PCIe host controller driver > >> on Qualcomm SoCs like Snapdragon 805. > >> > >> Signed-off-by: Stanimir Varbanov > >> --- > >> drivers/phy/Kconfig | 9 ++ > >> drivers/phy/Makefile | 1 + > >> drivers/phy/phy-qcom-pcie.c | 291 > >> +++++++++++++++++++++++++++++++++++++++++++ > > > > Why do you need a new PHY driver for this? Why not use the existing QCOM > > PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h? > > I agree that on first glance there are similarities, but I'm not sure > does the PHYs are the same IP blocks. Or at least they are different > revisions which have too many differences. So trying to combine them > will lead to more code than now. > > Either way I will try to understand how many the differences are. Ping, where are we with this? Should I wait for something else, or are you convinced there's enough difference to warrant a new PHY driver, Kishon? Bjorn