From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: [RFC v1 20/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t Date: Wed, 20 May 2015 12:16:46 +0200 Message-ID: <20150520101646.GB12898@samfundet.no> References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-21-git-send-email-jiang.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1432116013-25902-21-git-send-email-jiang.liu@linux.intel.com> Sender: sparclinux-owner@vger.kernel.org To: Jiang Liu Cc: Thomas Gleixner , Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Richard Henderson , Ivan Kokshaysky , Matt Turner , Haavard Skinnemoen , Steven Miao , Mark Salter , Aurelien Jacquiot , "David S. Miller" , Chris Metcalf , Guan Xuetao , x86@kernel.org, Rusty Russell , Andreas Larsson , Joe Perches , Christoph Lameter List-Id: linux-acpi@vger.kernel.org Around Wed 20 May 2015 18:00:08 +0800 or thereabout, Jiang Liu wrote: > Now most IRQ flow handlers make no use of the first parameter 'irq'. > And for those who do make use of 'irq', we could easily get the irq > number through irq_desc->irq_data->irq. So kill the first parameter > 'irq' of irq_flow_handler_t. > > To ease review, I have split the changes into several parts, though > they should be merge as one to support bisecting. > > Signed-off-by: Jiang Liu > --- > arch/alpha/kernel/irq.c | 2 +- > arch/avr32/mach-at32ap/extint.c | 2 +- > arch/avr32/mach-at32ap/pio.c | 2 +- For the AVR32 related bits Acked-by: Hans-Christian Egtvedt > arch/blackfin/kernel/ipipe.c | 4 ++-- > arch/c6x/platforms/megamod-pic.c | 3 ++- > arch/sparc/kernel/leon_kernel.c | 2 +- > arch/sparc/kernel/leon_pci_grpci1.c | 2 +- > arch/sparc/kernel/leon_pci_grpci2.c | 2 +- > arch/tile/kernel/pci_gx.c | 4 ++-- > arch/unicore32/kernel/irq.c | 3 ++- > arch/x86/kernel/irq_64.c | 2 +- > arch/x86/lguest/boot.c | 2 +- > 12 files changed, 16 insertions(+), 14 deletions(-) -- HcE From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753213AbbETKUy (ORCPT ); Wed, 20 May 2015 06:20:54 -0400 Received: from cassarossa.samfundet.no ([193.35.52.29]:48787 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbbETKUs (ORCPT ); Wed, 20 May 2015 06:20:48 -0400 Date: Wed, 20 May 2015 12:16:46 +0200 From: Hans-Christian Egtvedt To: Jiang Liu Cc: Thomas Gleixner , Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Richard Henderson , Ivan Kokshaysky , Matt Turner , Haavard Skinnemoen , Steven Miao , Mark Salter , Aurelien Jacquiot , "David S. Miller" , Chris Metcalf , Guan Xuetao , x86@kernel.org, Rusty Russell , Andreas Larsson , Joe Perches , Christoph Lameter , Brian Gerst , Konrad Rzeszutek Wilk , Tony Luck , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar , linux-alpha@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-c6x-dev@linux-c6x.org, sparclinux@vger.kernel.org, lguest@lists.ozlabs.org Subject: Re: [RFC v1 20/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t Message-ID: <20150520101646.GB12898@samfundet.no> References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-21-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432116013-25902-21-git-send-email-jiang.liu@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Around Wed 20 May 2015 18:00:08 +0800 or thereabout, Jiang Liu wrote: > Now most IRQ flow handlers make no use of the first parameter 'irq'. > And for those who do make use of 'irq', we could easily get the irq > number through irq_desc->irq_data->irq. So kill the first parameter > 'irq' of irq_flow_handler_t. > > To ease review, I have split the changes into several parts, though > they should be merge as one to support bisecting. > > Signed-off-by: Jiang Liu > --- > arch/alpha/kernel/irq.c | 2 +- > arch/avr32/mach-at32ap/extint.c | 2 +- > arch/avr32/mach-at32ap/pio.c | 2 +- For the AVR32 related bits Acked-by: Hans-Christian Egtvedt > arch/blackfin/kernel/ipipe.c | 4 ++-- > arch/c6x/platforms/megamod-pic.c | 3 ++- > arch/sparc/kernel/leon_kernel.c | 2 +- > arch/sparc/kernel/leon_pci_grpci1.c | 2 +- > arch/sparc/kernel/leon_pci_grpci2.c | 2 +- > arch/tile/kernel/pci_gx.c | 4 ++-- > arch/unicore32/kernel/irq.c | 3 ++- > arch/x86/kernel/irq_64.c | 2 +- > arch/x86/lguest/boot.c | 2 +- > 12 files changed, 16 insertions(+), 14 deletions(-) -- HcE From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Date: Wed, 20 May 2015 10:16:46 +0000 Subject: Re: [RFC v1 20/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t Message-Id: <20150520101646.GB12898@samfundet.no> List-Id: References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-21-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1432116013-25902-21-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jiang Liu Cc: Thomas Gleixner , Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Richard Henderson , Ivan Kokshaysky , Matt Turner , Haavard Skinnemoen , Steven Miao , Mark Salter , Aurelien Jacquiot , "David S. Miller" , Chris Metcalf , Guan Xuetao , x86@kernel.org, Rusty Russell , Andreas Larsson , Joe Perches , Christoph Lameter Around Wed 20 May 2015 18:00:08 +0800 or thereabout, Jiang Liu wrote: > Now most IRQ flow handlers make no use of the first parameter 'irq'. > And for those who do make use of 'irq', we could easily get the irq > number through irq_desc->irq_data->irq. So kill the first parameter > 'irq' of irq_flow_handler_t. > > To ease review, I have split the changes into several parts, though > they should be merge as one to support bisecting. > > Signed-off-by: Jiang Liu > --- > arch/alpha/kernel/irq.c | 2 +- > arch/avr32/mach-at32ap/extint.c | 2 +- > arch/avr32/mach-at32ap/pio.c | 2 +- For the AVR32 related bits Acked-by: Hans-Christian Egtvedt > arch/blackfin/kernel/ipipe.c | 4 ++-- > arch/c6x/platforms/megamod-pic.c | 3 ++- > arch/sparc/kernel/leon_kernel.c | 2 +- > arch/sparc/kernel/leon_pci_grpci1.c | 2 +- > arch/sparc/kernel/leon_pci_grpci2.c | 2 +- > arch/tile/kernel/pci_gx.c | 4 ++-- > arch/unicore32/kernel/irq.c | 3 ++- > arch/x86/kernel/irq_64.c | 2 +- > arch/x86/lguest/boot.c | 2 +- > 12 files changed, 16 insertions(+), 14 deletions(-) -- HcE