From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvKGj-0003No-9h for qemu-devel@nongnu.org; Thu, 21 May 2015 02:47:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvKGe-0006Jf-8C for qemu-devel@nongnu.org; Thu, 21 May 2015 02:47:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvKGd-0006JZ-W0 for qemu-devel@nongnu.org; Thu, 21 May 2015 02:47:44 -0400 Date: Thu, 21 May 2015 12:17:20 +0530 From: Amit Shah Message-ID: <20150521064720.GL15452@grmbl.mre> References: <1429031053-4454-1-git-send-email-dgilbert@redhat.com> <1429031053-4454-8-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429031053-4454-8-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 07/47] Move copy out of qemu_peek_buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au On (Tue) 14 Apr 2015 [18:03:33], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > qemu_peek_buffer currently copies the data it reads into a buffer, > however the next patch wants access to the buffer without the copy, > hence rework to remove the copy to the layer above. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah It's silly to do a copy in a peek function, so this is a good thing. Amit