From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754889AbbEUIA7 (ORCPT ); Thu, 21 May 2015 04:00:59 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:36215 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbbEUIAy (ORCPT ); Thu, 21 May 2015 04:00:54 -0400 Date: Thu, 21 May 2015 10:00:50 +0200 From: Thierry Reding To: Greg Kroah-Hartman Cc: Kevin Hilman , Scot Doyle , Tomi Valkeinen , Michael Kerrisk , Jiri Slaby , Jean-Christophe Plagniol-Villard , Pavel Machek , Geert Uytterhoeven , lkml , linux-fbdev@vger.kernel.org, linux-man@vger.kernel.org, linux-api@vger.kernel.org, Tyler Baker , Olof Johansson , Daniel Stone , Arnd Bergmann Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt Message-ID: <20150521080049.GA25079@ulmo> References: <20150325111949.GA24230@kroah.com> <20150519214011.GA27047@ulmo.nvidia.com> <20150519215228.GA27163@ulmo.nvidia.com> <20150519234112.GA25218@kroah.com> <20150520123615.GA24016@ulmo.nvidia.com> <20150521042638.GB22632@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <20150521042638.GB22632@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 20, 2015 at 09:26:38PM -0700, Greg Kroah-Hartman wrote: > On Wed, May 20, 2015 at 02:36:17PM +0200, Thierry Reding wrote: > > On Tue, May 19, 2015 at 04:41:12PM -0700, Greg Kroah-Hartman wrote: > > > On Tue, May 19, 2015 at 11:52:29PM +0200, Thierry Reding wrote: > > > > On Tue, May 19, 2015 at 02:45:19PM -0700, Kevin Hilman wrote: > > > > > On Tue, May 19, 2015 at 2:40 PM, Thierry Reding > > > > > wrote: > > > > > > On Tue, May 19, 2015 at 02:15:41PM -0700, Kevin Hilman wrote: > > > > > >> On Thu, Mar 26, 2015 at 6:56 AM, Scot Doyle wrote: > > > > > >> > vt now provides a cursor blink interval via vc_data. Use this > > > > > >> > interval instead of the currently hardcoded 200 msecs. Store= it in > > > > > >> > fbcon_ops to avoid locking the console in cursor_timer_handl= er(). > > > > > >> > > > > > > >> > Signed-off-by: Scot Doyle > > > > > >> > Acked-by: Pavel Machek > > > > > >> > > > > > >> This patch hit next-20150519 in the form of commit 27a4c827c34a > > > > > >> (fbcon: use the cursor blink interval provided by vt) and has = caused > > > > > >> boot failure on a handful of ARM platforms when booting a MMC = root > > > > > >> filesystem. This error was spotted by the kernelci.org bot on > > > > > >> exynos5800-peach-pi[1] and Thierry and Daniel (Cc'd) have seen= it on > > > > > >> some tegra platforms too. > > > > > >> > > > > > >> Thierry spotted this commit as a potential cause, and both Dan= iel and > > > > > >> I have reverted and boot tested on exynos5 and tegra respectiv= ely and > > > > > >> the boot panics disappear. > > > > > > > > > > > > FWIW, if I apply the below on top of next-20150519 things seem = to be > > > > > > back to normal as well: > > > > > > > > > > > > diff --git a/drivers/video/console/fbcon.c b/drivers/video/cons= ole/fbcon.c > > > > > > index 05b1d1a71ef9..658c34bb9076 100644 > > > > > > --- a/drivers/video/console/fbcon.c > > > > > > +++ b/drivers/video/console/fbcon.c > > > > > > @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *= vc, int mode) > > > > > > return; > > > > > > > > > > > > ops->cur_blink_jiffies =3D msecs_to_jiffies(vc->vc_cur_= blink_ms); > > > > > > - fbcon_del_cursor_timer(info); > > > > > > - if (!(vc->vc_cursor_type & 0x10)) > > > > > > + if (vc->vc_cursor_type & 0x10) > > > > > > + fbcon_del_cursor_timer(info); > > > > > > + else > > > > > > fbcon_add_cursor_timer(info); > > > > > > > > > > > > ops->cursor_flash =3D (mode =3D=3D CM_ERASE) ? 0 : 1; > > > > >=20 > > > > > Applying this on next-20150519 makes my exynos board happily boot= again as well. > > > > >=20 > > > > > Tested-by: Kevin Hilman > > > >=20 > > > > Excellent. Greg, Scot, any opinions on whether or not this is the r= ight > > > > thing to do? It restores a bit that looks suspiciously like it snuc= k in > > > > in the original (at least it isn't documented in the commit message= ). > > > >=20 > > > > Greg, feel free to squash this in if everybody agrees this is good = to > > > > go. If you prefer a patch on top let me know and I'll come up with a > > > > proper commit message. > > >=20 > > > Please send a real patch and I'll apply it on top, as I can't rebase = my > > > public tree. > >=20 > > Attached. >=20 > Ugh, no, please resend it as a stand-alone patch, I can't easily apply > attachments. Really? Your MUA can't dissect multipart messages? Anyway, sent separately for your convenience. Thierry --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVXZCuAAoJEN0jrNd/PrOhFGMQAIh7bka1458MGamwBYH57zPf LIZNr59c4gfMl3C7tmIazifGcRe9HYPQdL/sUjrKLZ9iVaHBuW6TUaqrOoubsVfw khIEgkO8KP1E6Gt8Z18iQX/Qbt+bz+p/OmN6pMhlQTRorz17wQrkbtyrV6c+Tsi9 /EH0siaKRPcN0ZuwsOimigbgSErxCCTtA7exAGmlFqbwUls3HVwj+eq43l1g++wS Tk31heQBdatThYGypqXY3mHlVEbFowujwxyfMoLNMwxjLdIlMVcdVvznwrYMuVQy KgjU6DbunA9Z9v8ERWZZwGSOjBU4jFYBnKUbl3zZI66Y3fpcUqt1uq8XrC7Cj8k1 e1M5c7cYrWzPIqDsoM4UNf/Rkj4+pCHnsBpF+IbdqvQvteosXOnMrG08wxLb3hUm Vgd/ShbtPe2aMLeN2WrASjNRl8JkbJmOOIFRbSEB3iRrYiWFxzuu+sqvK5DE+eDd MT1dnexGNSb4dMrv07Yq2DiFRl2L/hrpikbKUTf9js3vi7wNNIggYBX5Ctpppigd 4HyyUCI/afODKWsZQdRJtV+nl5A4Jlkd5hfYY+688XGiaJWAO/TPrvpEC5iN9TIM 8Iv4PXch20M75SU1zy16w6c2rKDxK2JjHSX12c9akpwx6nwanQVSKVLMPtj0PW32 Jg/Bkdfo+RHBcpenyQwI =Azwq -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt Date: Thu, 21 May 2015 10:00:50 +0200 Message-ID: <20150521080049.GA25079@ulmo> References: <20150325111949.GA24230@kroah.com> <20150519214011.GA27047@ulmo.nvidia.com> <20150519215228.GA27163@ulmo.nvidia.com> <20150519234112.GA25218@kroah.com> <20150520123615.GA24016@ulmo.nvidia.com> <20150521042638.GB22632@kroah.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Return-path: Content-Disposition: inline In-Reply-To: <20150521042638.GB22632-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kroah-Hartman Cc: Kevin Hilman , Scot Doyle , Tomi Valkeinen , Michael Kerrisk , Jiri Slaby , Jean-Christophe Plagniol-Villard , Pavel Machek , Geert Uytterhoeven , lkml , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tyler Baker , Olof Johansson , Daniel Stone , Arnd Bergmann List-Id: linux-man@vger.kernel.org --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 20, 2015 at 09:26:38PM -0700, Greg Kroah-Hartman wrote: > On Wed, May 20, 2015 at 02:36:17PM +0200, Thierry Reding wrote: > > On Tue, May 19, 2015 at 04:41:12PM -0700, Greg Kroah-Hartman wrote: > > > On Tue, May 19, 2015 at 11:52:29PM +0200, Thierry Reding wrote: > > > > On Tue, May 19, 2015 at 02:45:19PM -0700, Kevin Hilman wrote: > > > > > On Tue, May 19, 2015 at 2:40 PM, Thierry Reding > > > > > wrote: > > > > > > On Tue, May 19, 2015 at 02:15:41PM -0700, Kevin Hilman wrote: > > > > > >> On Thu, Mar 26, 2015 at 6:56 AM, Scot Doyle wrote: > > > > > >> > vt now provides a cursor blink interval via vc_data. Use this > > > > > >> > interval instead of the currently hardcoded 200 msecs. Store= it in > > > > > >> > fbcon_ops to avoid locking the console in cursor_timer_handl= er(). > > > > > >> > > > > > > >> > Signed-off-by: Scot Doyle > > > > > >> > Acked-by: Pavel Machek > > > > > >> > > > > > >> This patch hit next-20150519 in the form of commit 27a4c827c34a > > > > > >> (fbcon: use the cursor blink interval provided by vt) and has = caused > > > > > >> boot failure on a handful of ARM platforms when booting a MMC = root > > > > > >> filesystem. This error was spotted by the kernelci.org bot on > > > > > >> exynos5800-peach-pi[1] and Thierry and Daniel (Cc'd) have seen= it on > > > > > >> some tegra platforms too. > > > > > >> > > > > > >> Thierry spotted this commit as a potential cause, and both Dan= iel and > > > > > >> I have reverted and boot tested on exynos5 and tegra respectiv= ely and > > > > > >> the boot panics disappear. > > > > > > > > > > > > FWIW, if I apply the below on top of next-20150519 things seem = to be > > > > > > back to normal as well: > > > > > > > > > > > > diff --git a/drivers/video/console/fbcon.c b/drivers/video/cons= ole/fbcon.c > > > > > > index 05b1d1a71ef9..658c34bb9076 100644 > > > > > > --- a/drivers/video/console/fbcon.c > > > > > > +++ b/drivers/video/console/fbcon.c > > > > > > @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *= vc, int mode) > > > > > > return; > > > > > > > > > > > > ops->cur_blink_jiffies =3D msecs_to_jiffies(vc->vc_cur_= blink_ms); > > > > > > - fbcon_del_cursor_timer(info); > > > > > > - if (!(vc->vc_cursor_type & 0x10)) > > > > > > + if (vc->vc_cursor_type & 0x10) > > > > > > + fbcon_del_cursor_timer(info); > > > > > > + else > > > > > > fbcon_add_cursor_timer(info); > > > > > > > > > > > > ops->cursor_flash =3D (mode =3D=3D CM_ERASE) ? 0 : 1; > > > > >=20 > > > > > Applying this on next-20150519 makes my exynos board happily boot= again as well. > > > > >=20 > > > > > Tested-by: Kevin Hilman > > > >=20 > > > > Excellent. Greg, Scot, any opinions on whether or not this is the r= ight > > > > thing to do? It restores a bit that looks suspiciously like it snuc= k in > > > > in the original (at least it isn't documented in the commit message= ). > > > >=20 > > > > Greg, feel free to squash this in if everybody agrees this is good = to > > > > go. If you prefer a patch on top let me know and I'll come up with a > > > > proper commit message. > > >=20 > > > Please send a real patch and I'll apply it on top, as I can't rebase = my > > > public tree. > >=20 > > Attached. >=20 > Ugh, no, please resend it as a stand-alone patch, I can't easily apply > attachments. Really? Your MUA can't dissect multipart messages? Anyway, sent separately for your convenience. Thierry --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVXZCuAAoJEN0jrNd/PrOhFGMQAIh7bka1458MGamwBYH57zPf LIZNr59c4gfMl3C7tmIazifGcRe9HYPQdL/sUjrKLZ9iVaHBuW6TUaqrOoubsVfw khIEgkO8KP1E6Gt8Z18iQX/Qbt+bz+p/OmN6pMhlQTRorz17wQrkbtyrV6c+Tsi9 /EH0siaKRPcN0ZuwsOimigbgSErxCCTtA7exAGmlFqbwUls3HVwj+eq43l1g++wS Tk31heQBdatThYGypqXY3mHlVEbFowujwxyfMoLNMwxjLdIlMVcdVvznwrYMuVQy KgjU6DbunA9Z9v8ERWZZwGSOjBU4jFYBnKUbl3zZI66Y3fpcUqt1uq8XrC7Cj8k1 e1M5c7cYrWzPIqDsoM4UNf/Rkj4+pCHnsBpF+IbdqvQvteosXOnMrG08wxLb3hUm Vgd/ShbtPe2aMLeN2WrASjNRl8JkbJmOOIFRbSEB3iRrYiWFxzuu+sqvK5DE+eDd MT1dnexGNSb4dMrv07Yq2DiFRl2L/hrpikbKUTf9js3vi7wNNIggYBX5Ctpppigd 4HyyUCI/afODKWsZQdRJtV+nl5A4Jlkd5hfYY+688XGiaJWAO/TPrvpEC5iN9TIM 8Iv4PXch20M75SU1zy16w6c2rKDxK2JjHSX12c9akpwx6nwanQVSKVLMPtj0PW32 Jg/Bkdfo+RHBcpenyQwI =Azwq -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Thu, 21 May 2015 08:00:50 +0000 Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt Message-Id: <20150521080049.GA25079@ulmo> MIME-Version: 1 Content-Type: multipart/mixed; boundary="5mCyUwZo2JvN/JJP" List-Id: References: <20150325111949.GA24230@kroah.com> <20150519214011.GA27047@ulmo.nvidia.com> <20150519215228.GA27163@ulmo.nvidia.com> <20150519234112.GA25218@kroah.com> <20150520123615.GA24016@ulmo.nvidia.com> <20150521042638.GB22632@kroah.com> In-Reply-To: <20150521042638.GB22632-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> To: Greg Kroah-Hartman Cc: Kevin Hilman , Scot Doyle , Tomi Valkeinen , Michael Kerrisk , Jiri Slaby , Jean-Christophe Plagniol-Villard , Pavel Machek , Geert Uytterhoeven , lkml , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tyler Baker , Olof Johansson , Daniel Stone , Arnd Bergmann --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 20, 2015 at 09:26:38PM -0700, Greg Kroah-Hartman wrote: > On Wed, May 20, 2015 at 02:36:17PM +0200, Thierry Reding wrote: > > On Tue, May 19, 2015 at 04:41:12PM -0700, Greg Kroah-Hartman wrote: > > > On Tue, May 19, 2015 at 11:52:29PM +0200, Thierry Reding wrote: > > > > On Tue, May 19, 2015 at 02:45:19PM -0700, Kevin Hilman wrote: > > > > > On Tue, May 19, 2015 at 2:40 PM, Thierry Reding > > > > > wrote: > > > > > > On Tue, May 19, 2015 at 02:15:41PM -0700, Kevin Hilman wrote: > > > > > >> On Thu, Mar 26, 2015 at 6:56 AM, Scot Doyle wrote: > > > > > >> > vt now provides a cursor blink interval via vc_data. Use this > > > > > >> > interval instead of the currently hardcoded 200 msecs. Store= it in > > > > > >> > fbcon_ops to avoid locking the console in cursor_timer_handl= er(). > > > > > >> > > > > > > >> > Signed-off-by: Scot Doyle > > > > > >> > Acked-by: Pavel Machek > > > > > >> > > > > > >> This patch hit next-20150519 in the form of commit 27a4c827c34a > > > > > >> (fbcon: use the cursor blink interval provided by vt) and has = caused > > > > > >> boot failure on a handful of ARM platforms when booting a MMC = root > > > > > >> filesystem. This error was spotted by the kernelci.org bot on > > > > > >> exynos5800-peach-pi[1] and Thierry and Daniel (Cc'd) have seen= it on > > > > > >> some tegra platforms too. > > > > > >> > > > > > >> Thierry spotted this commit as a potential cause, and both Dan= iel and > > > > > >> I have reverted and boot tested on exynos5 and tegra respectiv= ely and > > > > > >> the boot panics disappear. > > > > > > > > > > > > FWIW, if I apply the below on top of next-20150519 things seem = to be > > > > > > back to normal as well: > > > > > > > > > > > > diff --git a/drivers/video/console/fbcon.c b/drivers/video/cons= ole/fbcon.c > > > > > > index 05b1d1a71ef9..658c34bb9076 100644 > > > > > > --- a/drivers/video/console/fbcon.c > > > > > > +++ b/drivers/video/console/fbcon.c > > > > > > @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *= vc, int mode) > > > > > > return; > > > > > > > > > > > > ops->cur_blink_jiffies =3D msecs_to_jiffies(vc->vc_cur_= blink_ms); > > > > > > - fbcon_del_cursor_timer(info); > > > > > > - if (!(vc->vc_cursor_type & 0x10)) > > > > > > + if (vc->vc_cursor_type & 0x10) > > > > > > + fbcon_del_cursor_timer(info); > > > > > > + else > > > > > > fbcon_add_cursor_timer(info); > > > > > > > > > > > > ops->cursor_flash =3D (mode =3D=3D CM_ERASE) ? 0 : 1; > > > > >=20 > > > > > Applying this on next-20150519 makes my exynos board happily boot= again as well. > > > > >=20 > > > > > Tested-by: Kevin Hilman > > > >=20 > > > > Excellent. Greg, Scot, any opinions on whether or not this is the r= ight > > > > thing to do? It restores a bit that looks suspiciously like it snuc= k in > > > > in the original (at least it isn't documented in the commit message= ). > > > >=20 > > > > Greg, feel free to squash this in if everybody agrees this is good = to > > > > go. If you prefer a patch on top let me know and I'll come up with a > > > > proper commit message. > > >=20 > > > Please send a real patch and I'll apply it on top, as I can't rebase = my > > > public tree. > >=20 > > Attached. >=20 > Ugh, no, please resend it as a stand-alone patch, I can't easily apply > attachments. Really? Your MUA can't dissect multipart messages? Anyway, sent separately for your convenience. Thierry --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVXZCuAAoJEN0jrNd/PrOhFGMQAIh7bka1458MGamwBYH57zPf LIZNr59c4gfMl3C7tmIazifGcRe9HYPQdL/sUjrKLZ9iVaHBuW6TUaqrOoubsVfw khIEgkO8KP1E6Gt8Z18iQX/Qbt+bz+p/OmN6pMhlQTRorz17wQrkbtyrV6c+Tsi9 /EH0siaKRPcN0ZuwsOimigbgSErxCCTtA7exAGmlFqbwUls3HVwj+eq43l1g++wS Tk31heQBdatThYGypqXY3mHlVEbFowujwxyfMoLNMwxjLdIlMVcdVvznwrYMuVQy KgjU6DbunA9Z9v8ERWZZwGSOjBU4jFYBnKUbl3zZI66Y3fpcUqt1uq8XrC7Cj8k1 e1M5c7cYrWzPIqDsoM4UNf/Rkj4+pCHnsBpF+IbdqvQvteosXOnMrG08wxLb3hUm Vgd/ShbtPe2aMLeN2WrASjNRl8JkbJmOOIFRbSEB3iRrYiWFxzuu+sqvK5DE+eDd MT1dnexGNSb4dMrv07Yq2DiFRl2L/hrpikbKUTf9js3vi7wNNIggYBX5Ctpppigd 4HyyUCI/afODKWsZQdRJtV+nl5A4Jlkd5hfYY+688XGiaJWAO/TPrvpEC5iN9TIM 8Iv4PXch20M75SU1zy16w6c2rKDxK2JjHSX12c9akpwx6nwanQVSKVLMPtj0PW32 Jg/Bkdfo+RHBcpenyQwI =Azwq -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--