From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v8 02/11] eal/linux: add rte_epoll_wait/ctl
 support
Date: Thu, 21 May 2015 11:22:05 -0700
Message-ID: <20150521112205.4caf6bd0@urahara>
References: <1430804386-28949-1-git-send-email-cunming.liang@intel.com>
 <1432198563-16334-1-git-send-email-cunming.liang@intel.com>
 <1432198563-16334-3-git-send-email-cunming.liang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, liang-min.wang@intel.com
To: Cunming Liang <cunming.liang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com
 [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id AFE7E5A0A
 for <dev@dpdk.org>; Thu, 21 May 2015 20:22:07 +0200 (CEST)
Received: by pabts4 with SMTP id ts4so113380762pab.3
 for <dev@dpdk.org>; Thu, 21 May 2015 11:22:07 -0700 (PDT)
In-Reply-To: <1432198563-16334-3-git-send-email-cunming.liang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 21 May 2015 16:55:54 +0800
Cunming Liang <cunming.liang@intel.com> wrote:

> +static int
> +eal_epoll_process_event(struct epoll_event *evs, int n,
> +			struct rte_epoll_event *events)
> +{
> +	int i;
> +	int count = 0;
> +	struct rte_epoll_event *rev;
> +	for (i = 0; i < n; i++) {
> +		rev = (struct rte_epoll_event *)evs[i].data.ptr;
> +		if (!rev || !rte_atomic32_cmpset(&rev->status, RTE_EPOLL_VALID,
> +						 RTE_EPOLL_EXEC))
> +			continue;
> +
> +		events[count].status        = RTE_EPOLL_VALID;
> +		events[count].fd            = rev->fd;
> +		events[count].epfd          = rev->epfd;
> +		events[count].epdata.event  = rev->epdata.event;
> +		events[count].epdata.data   = rev->epdata.data;

This code has several style issues:
 1. Always put blank line after declarations

 2. Use unsigned where ever it makes sense as a matter of habit.
      unsigned int i, count = 0;

 3. Don't add casts where not necessary, it reduces compiler type checking
    and is a bad habit. In this case evs[i].data.ptr is void *
    and therefore no cast is needed.