From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422658AbbEUWCF (ORCPT ); Thu, 21 May 2015 18:02:05 -0400 Received: from mail.skyhub.de ([78.46.96.112]:37176 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755334AbbEUWCD (ORCPT ); Thu, 21 May 2015 18:02:03 -0400 Date: Fri, 22 May 2015 00:01:58 +0200 From: Borislav Petkov To: Josh Poimboeuf Cc: Ingo Molnar , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Andy Lutomirski , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Andrew Morton Subject: Re: [PATCH v4 0/3] Compile-time stack frame pointer validation Message-ID: <20150521220158.GH3689@pd.tnic> References: <20150520103339.GA22205@gmail.com> <20150520141331.GA16995@treble.redhat.com> <20150520144810.GA10374@gmail.com> <20150521205425.GA31662@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150521205425.GA31662@treble.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2015 at 03:54:25PM -0500, Josh Poimboeuf wrote: > stackvalidate: arch/x86/lib/memmove_64.o: return instruction outside of a function at .altinstr_replacement+0x5 That must be something like this: 0000000000000000 <.altinstr_replacement>: 0: 48 89 d1 mov %rdx,%rcx 3: f3 a4 rep movsb %ds:(%rsi),%es:(%rdi) 5: c3 retq right? In any case, anything with alternatives is probably a false positive because even if instructions appear outside of the containing function, they get patched in and are actually inside. Jump offsets get fixed up properly too. Should, at least :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --