From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips Date: Thu, 21 May 2015 18:28:16 -0400 Message-ID: <20150521222816.GO4914@htj.duckdns.org> References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> <20150521222059.GM4914@htj.duckdns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qg0-f53.google.com ([209.85.192.53]:34771 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756098AbbEUW2V (ORCPT ); Thu, 21 May 2015 18:28:21 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Brian Norris Cc: Fabio Estevam , Kishon Vijay Abraham I , Mark Rutland , "devicetree@vger.kernel.org" , Hans de Goede , Florian Fainelli , Pawel Moll , Ian Campbell , Kevin Cernekee , linux-kernel , linux-ide@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list , Gregory Fong , Kumar Gala , "linux-arm-kernel@lists.infradead.org" On Thu, May 21, 2015 at 03:26:10PM -0700, Brian Norris wrote: > On Thu, May 21, 2015 at 3:20 PM, Tejun Heo wrote: > > On Thu, May 21, 2015 at 07:16:07PM -0300, Fabio Estevam wrote: > >> On Tue, May 12, 2015 at 8:28 PM, Brian Norris > >> wrote: > >> > >> > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > >> > + ahci = devm_ioremap_resource(&pdev->dev, res); > >> > + if (IS_ERR(ahci)) > >> > + return 0; > >> > >> You should propagate 'return PTR_ERR(ahci)' instead. > > > > Brian, can you please update the patch? > > Note how the function brcm_ahci_get_portmask() is used. In brcm_ahci_probe(): > > priv->port_mask = brcm_ahci_get_portmask(pdev, priv); > if (!priv->port_mask) > return -ENODEV; > > I could try to change the return semantics if really needed. Or I > could add some comments on brcm_ahci_get_portmask() to note its return > semantics. Or I could just leave the driver as-is. Your call. Ah, you're right. It's fine. Leave it alone. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756901AbbEUW20 (ORCPT ); Thu, 21 May 2015 18:28:26 -0400 Received: from mail-qg0-f53.google.com ([209.85.192.53]:34771 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756098AbbEUW2V (ORCPT ); Thu, 21 May 2015 18:28:21 -0400 Date: Thu, 21 May 2015 18:28:16 -0400 From: Tejun Heo To: Brian Norris Cc: Fabio Estevam , Kishon Vijay Abraham I , Mark Rutland , "devicetree@vger.kernel.org" , Hans de Goede , Florian Fainelli , Pawel Moll , Ian Campbell , Kevin Cernekee , linux-kernel , linux-ide@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list , Gregory Fong , Kumar Gala , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips Message-ID: <20150521222816.GO4914@htj.duckdns.org> References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> <20150521222059.GM4914@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2015 at 03:26:10PM -0700, Brian Norris wrote: > On Thu, May 21, 2015 at 3:20 PM, Tejun Heo wrote: > > On Thu, May 21, 2015 at 07:16:07PM -0300, Fabio Estevam wrote: > >> On Tue, May 12, 2015 at 8:28 PM, Brian Norris > >> wrote: > >> > >> > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > >> > + ahci = devm_ioremap_resource(&pdev->dev, res); > >> > + if (IS_ERR(ahci)) > >> > + return 0; > >> > >> You should propagate 'return PTR_ERR(ahci)' instead. > > > > Brian, can you please update the patch? > > Note how the function brcm_ahci_get_portmask() is used. In brcm_ahci_probe(): > > priv->port_mask = brcm_ahci_get_portmask(pdev, priv); > if (!priv->port_mask) > return -ENODEV; > > I could try to change the return semantics if really needed. Or I > could add some comments on brcm_ahci_get_portmask() to note its return > semantics. Or I could just leave the driver as-is. Your call. Ah, you're right. It's fine. Leave it alone. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: tj@kernel.org (Tejun Heo) Date: Thu, 21 May 2015 18:28:16 -0400 Subject: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips In-Reply-To: References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> <20150521222059.GM4914@htj.duckdns.org> Message-ID: <20150521222816.GO4914@htj.duckdns.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 21, 2015 at 03:26:10PM -0700, Brian Norris wrote: > On Thu, May 21, 2015 at 3:20 PM, Tejun Heo wrote: > > On Thu, May 21, 2015 at 07:16:07PM -0300, Fabio Estevam wrote: > >> On Tue, May 12, 2015 at 8:28 PM, Brian Norris > >> wrote: > >> > >> > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > >> > + ahci = devm_ioremap_resource(&pdev->dev, res); > >> > + if (IS_ERR(ahci)) > >> > + return 0; > >> > >> You should propagate 'return PTR_ERR(ahci)' instead. > > > > Brian, can you please update the patch? > > Note how the function brcm_ahci_get_portmask() is used. In brcm_ahci_probe(): > > priv->port_mask = brcm_ahci_get_portmask(pdev, priv); > if (!priv->port_mask) > return -ENODEV; > > I could try to change the return semantics if really needed. Or I > could add some comments on brcm_ahci_get_portmask() to note its return > semantics. Or I could just leave the driver as-is. Your call. Ah, you're right. It's fine. Leave it alone. Thanks. -- tejun