From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Micky Ching <micky_ching@realsil.com.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: remove always true comparison
Date: Mon, 25 May 2015 19:22:40 +0300 [thread overview]
Message-ID: <20150525162240.GA11734@mwanda> (raw)
In-Reply-To: <20150515101649.GA9605@sudip-PC>
On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote:
> On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
> > On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
> > > the if comparison is always true as anything bitwise and-ing with 0x1E
> > > can never be equal to 0x03.
> > >
> > > Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881
> > >
> >
> > It doesn't fix anything though, it just silences the warning. Warnings
> > are nice because they let you know that the code is buggy. It's better
> > to leave them there instead of making the bugs more complicated to find.
>
> but I am not seeing any warnings. I tried with make W=1, tried with
> sparse, but still no warning. am i missing something?
David Binderman is using a static checker of some kind. I'm not sure
which. It might be cppcheck or it might be something private.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-25 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 14:25 [PATCH] staging: rts5208: remove always true comparison Sudip Mukherjee
2015-05-14 15:18 ` Dan Carpenter
2015-05-15 10:16 ` Sudip Mukherjee
2015-05-25 16:22 ` Dan Carpenter [this message]
2015-05-26 4:55 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525162240.GA11734@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.