From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752552AbbE0LaW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 07:30:22 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34888 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751322AbbE0LaU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 07:30:20 -0400
Date: Wed, 27 May 2015 13:30:08 +0200
From: Borislav Petkov <bp@suse.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Huang Rui <ray.huang@amd.com>, Thomas Gleixner <tglx@linutronix.de>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        John Stultz <john.stultz@linaro.org>, Tony Li <tony.li@amd.com>,
        X86 ML <x86@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Aaron Lu <aaron.lu@intel.com>, Fengguang Wu <fengguang.wu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/4] x86, mwaitt: introduce mwaitx idle with a
 configurable timer
Message-ID: <20150527113008.GB19582@pd.tnic>
References: <1432022472-2224-1-git-send-email-ray.huang@amd.com>
 <1432022472-2224-3-git-send-email-ray.huang@amd.com>
 <555D3629.8080002@kernel.org>
 <CALCETrXTu=Bap0URw6VkxG=L7a7+fNq4qZG2Fa6xbtps_JhqxQ@mail.gmail.com>
 <CALCETrXgeMcC-H-S7Y=mP9cbP057m7a2dDEnACK-fJbz3cRjKw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALCETrXgeMcC-H-S7Y=mP9cbP057m7a2dDEnACK-fJbz3cRjKw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 26, 2015 at 06:01:03PM -0700, Andy Lutomirski wrote:
> https://chromium-review.googlesource.com/#/c/205161/
> 
> Oddly, Coreboot seems to have mis-spelled that MSR.  It's
> MSR_PKG_CST_CONFIG_CONTROL, and bit 31 isn't defined in the SDM
> (unsurprisingly).

Since this MSR is a control MSR and from looking at the comment in the
coreboot code and how they set that bit, it enables that MWAIT variant.
Even if the MSR write would stick on your hw, though, you'd still need
to know what it takes into EAX/ECX (and possibly some other register...
EBX, EDX...?) It might bring you some fun while trying to figure it out
:-)

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--