From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:33944 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755162AbbE1XYE (ORCPT ); Thu, 28 May 2015 19:24:04 -0400 Date: Thu, 28 May 2015 16:24:02 -0700 From: Andrew Morton To: Jan Kara Cc: linux-mm@kvack.org, linux-media@vger.kernel.org, Hans Verkuil , dri-devel@lists.freedesktop.org, Pawel Osciak , Mauro Carvalho Chehab , mgorman@suse.de, Marek Szyprowski , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper Message-Id: <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> In-Reply-To: <1431522495-4692-3-git-send-email-jack@suse.cz> References: <1431522495-4692-1-git-send-email-jack@suse.cz> <1431522495-4692-3-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, 13 May 2015 15:08:08 +0200 Jan Kara wrote: > Provide new function get_vaddr_frames(). This function maps virtual > addresses from given start and fills given array with page frame numbers of > the corresponding pages. If given start belongs to a normal vma, the function > grabs reference to each of the pages to pin them in memory. If start > belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller > must make sure pfns aren't reused for anything else while he is using > them. > > This function is created for various drivers to simplify handling of > their buffers. > > Acked-by: Mel Gorman > Acked-by: Vlastimil Babka > Signed-off-by: Jan Kara > --- > include/linux/mm.h | 44 +++++++++++ > mm/gup.c | 226 +++++++++++++++++++++++++++++++++++++++++++++++++++++ That's a lump of new code which many kernels won't be needing. Can we put all this in a new .c file and select it within drivers/media Kconfig? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper Date: Thu, 28 May 2015 16:24:02 -0700 Message-ID: <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> References: <1431522495-4692-1-git-send-email-jack@suse.cz> <1431522495-4692-3-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1431522495-4692-3-git-send-email-jack@suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jan Kara Cc: linux-samsung-soc@vger.kernel.org, Pawel Osciak , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, mgorman@suse.de, Marek Szyprowski , linux-media@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org T24gV2VkLCAxMyBNYXkgMjAxNSAxNTowODowOCArMDIwMCBKYW4gS2FyYSA8amFja0BzdXNlLmN6 PiB3cm90ZToKCj4gUHJvdmlkZSBuZXcgZnVuY3Rpb24gZ2V0X3ZhZGRyX2ZyYW1lcygpLiAgVGhp cyBmdW5jdGlvbiBtYXBzIHZpcnR1YWwKPiBhZGRyZXNzZXMgZnJvbSBnaXZlbiBzdGFydCBhbmQg ZmlsbHMgZ2l2ZW4gYXJyYXkgd2l0aCBwYWdlIGZyYW1lIG51bWJlcnMgb2YKPiB0aGUgY29ycmVz cG9uZGluZyBwYWdlcy4gSWYgZ2l2ZW4gc3RhcnQgYmVsb25ncyB0byBhIG5vcm1hbCB2bWEsIHRo ZSBmdW5jdGlvbgo+IGdyYWJzIHJlZmVyZW5jZSB0byBlYWNoIG9mIHRoZSBwYWdlcyB0byBwaW4g dGhlbSBpbiBtZW1vcnkuIElmIHN0YXJ0Cj4gYmVsb25ncyB0byBWTV9JTyB8IFZNX1BGTk1BUCB2 bWEsIHdlIGRvbid0IHRvdWNoIHBhZ2Ugc3RydWN0dXJlcy4gQ2FsbGVyCj4gbXVzdCBtYWtlIHN1 cmUgcGZucyBhcmVuJ3QgcmV1c2VkIGZvciBhbnl0aGluZyBlbHNlIHdoaWxlIGhlIGlzIHVzaW5n Cj4gdGhlbS4KPiAKPiBUaGlzIGZ1bmN0aW9uIGlzIGNyZWF0ZWQgZm9yIHZhcmlvdXMgZHJpdmVy cyB0byBzaW1wbGlmeSBoYW5kbGluZyBvZgo+IHRoZWlyIGJ1ZmZlcnMuCj4gCj4gQWNrZWQtYnk6 IE1lbCBHb3JtYW4gPG1nb3JtYW5Ac3VzZS5kZT4KPiBBY2tlZC1ieTogVmxhc3RpbWlsIEJhYmth IDx2YmFia2FAc3VzZS5jej4KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gS2FyYSA8amFja0BzdXNlLmN6 Pgo+IC0tLQo+ICBpbmNsdWRlL2xpbnV4L21tLmggfCAgNDQgKysrKysrKysrKysKPiAgbW0vZ3Vw LmMgICAgICAgICAgIHwgMjI2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCgpUaGF0J3MgYSBsdW1wIG9mIG5ldyBjb2RlIHdoaWNoIG1hbnkga2Vy bmVscyB3b24ndCBiZSBuZWVkaW5nLiAgQ2FuIHdlCnB1dCBhbGwgdGhpcyBpbiBhIG5ldyAuYyBm aWxlIGFuZCBzZWxlY3QgaXQgd2l0aGluIGRyaXZlcnMvbWVkaWEKS2NvbmZpZz8KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by kanga.kvack.org (Postfix) with ESMTP id 98E556B006E for ; Thu, 28 May 2015 19:24:04 -0400 (EDT) Received: by pdbqa5 with SMTP id qa5so52214962pdb.0 for ; Thu, 28 May 2015 16:24:04 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id pf6si5714888pbb.67.2015.05.28.16.24.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 16:24:03 -0700 (PDT) Date: Thu, 28 May 2015 16:24:02 -0700 From: Andrew Morton Subject: Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper Message-Id: <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> In-Reply-To: <1431522495-4692-3-git-send-email-jack@suse.cz> References: <1431522495-4692-1-git-send-email-jack@suse.cz> <1431522495-4692-3-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jan Kara Cc: linux-mm@kvack.org, linux-media@vger.kernel.org, Hans Verkuil , dri-devel@lists.freedesktop.org, Pawel Osciak , Mauro Carvalho Chehab , mgorman@suse.de, Marek Szyprowski , linux-samsung-soc@vger.kernel.org On Wed, 13 May 2015 15:08:08 +0200 Jan Kara wrote: > Provide new function get_vaddr_frames(). This function maps virtual > addresses from given start and fills given array with page frame numbers of > the corresponding pages. If given start belongs to a normal vma, the function > grabs reference to each of the pages to pin them in memory. If start > belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller > must make sure pfns aren't reused for anything else while he is using > them. > > This function is created for various drivers to simplify handling of > their buffers. > > Acked-by: Mel Gorman > Acked-by: Vlastimil Babka > Signed-off-by: Jan Kara > --- > include/linux/mm.h | 44 +++++++++++ > mm/gup.c | 226 +++++++++++++++++++++++++++++++++++++++++++++++++++++ That's a lump of new code which many kernels won't be needing. Can we put all this in a new .c file and select it within drivers/media Kconfig? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org