From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932211AbbE1Sdk (ORCPT ); Thu, 28 May 2015 14:33:40 -0400 Received: from mail.skyhub.de ([78.46.96.112]:40297 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932143AbbE1Sde (ORCPT ); Thu, 28 May 2015 14:33:34 -0400 Date: Thu, 28 May 2015 20:33:21 +0200 From: Borislav Petkov To: "H. Peter Anvin" Cc: Prarit Bhargava , Joe Perches , luto@amacapital.net, peterz@infradead.org, dvlasenk@redhat.com, torvalds@linux-foundation.org, imammedo@redhat.com, brgerst@gmail.com, mingo@kernel.org, dave.hansen@linux.intel.com, fenghua.yu@intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, bp@suse.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/cpu] x86/cpu: Strip any /proc/ cpuinfo model name field whitespace Message-ID: <20150528183321.GD31800@pd.tnic> References: <1432050210-32036-1-git-send-email-prarit@redhat.com> <1432628901-18044-15-git-send-email-bp@alien8.de> <1432746454.2846.154.camel@perches.com> <20150527190626.GC19407@pd.tnic> <1432754207.2846.162.camel@perches.com> <5566FB97.5020904@redhat.com> <20150528113229.GA31800@pd.tnic> <20150528125819.GB31800@pd.tnic> <2A88ADE0-90EF-4A94-BF4D-463E478B2FDA@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2A88ADE0-90EF-4A94-BF4D-463E478B2FDA@zytor.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 09:57:15AM -0700, H. Peter Anvin wrote: > Why?! > > We are taking about 48 bytes run once per cpu. It isn't worth it to > optimize, in fact the extra code size hurts more. I wanted to save us the redundant copying of the exact same bytes. Because when there's no preceding whitespace, p and q point at the same thing so we end up doing *p = *p. OTOH, without the optimization, the code is even simpler. I can remove it if you wanna - I don't care all that much. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --