From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Peng Subject: Re: [PATCH v8 05/13] x86: expose CBM length and COS number information Date: Fri, 29 May 2015 10:47:13 +0800 Message-ID: <20150529024713.GD18422@pengc-linux.bj.intel.com> References: <1432197704-20816-1-git-send-email-chao.p.peng@linux.intel.com> <1432197704-20816-6-git-send-email-chao.p.peng@linux.intel.com> <5567338B020000780007E9AE@mail.emea.novell.com> Reply-To: Chao Peng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5567338B020000780007E9AE@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, keir@xen.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On Thu, May 28, 2015 at 02:26:03PM +0100, Jan Beulich wrote: > > > --- a/xen/include/public/sysctl.h > > +++ b/xen/include/public/sysctl.h > > @@ -694,6 +694,20 @@ struct xen_sysctl_pcitopoinfo { > > typedef struct xen_sysctl_pcitopoinfo xen_sysctl_pcitopoinfo_t; > > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_pcitopoinfo_t); > > > > +#define XEN_SYSCTL_PSR_CAT_get_l3_info 0 > > +struct xen_sysctl_psr_cat_op { > > + uint32_t cmd; /* IN: XEN_SYSCTL_PSR_CAT_* */ > > + uint32_t target; /* IN: socket to be operated on */ > > If this is always the socket number, why would the variable be > named anything other than "socket". If otoh subsequent patches > use it differently, I think the comment should be omitted now > rather than being dropped then (or it should be given its final > wording from the beginning). Or 'target to be operated on'? Chao