From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755623AbbE2IEs (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 May 2015 04:04:48 -0400
Received: from mail-wg0-f46.google.com ([74.125.82.46]:33744 "EHLO
	mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755244AbbE2IE3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 May 2015 04:04:29 -0400
Date: Fri, 29 May 2015 10:04:25 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Balbir Singh <bsingharora@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] proc/schedstat: Expose /proc/<pid>/schedstat if delay
 accounting is enabled
Message-ID: <20150529080424.GA27235@gmail.com>
References: <1432537954-26665-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com>
 <CAKTCnzm5A6n=jvskHqUmpdq7yynzKqwuVFJL-ia=3PmgDeBV-w@mail.gmail.com>
 <20150529061620.GA17421@naverao1-tp.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150529061620.GA17421@naverao1-tp.ibm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> wrote:

> /proc/<pid>/schedstat is currently only available if CONFIG_SCHEDSTATS is
> enabled. But, all the fields that this exposes are available and valid
> if CONFIG_TASK_DELAY_ACCT is enabled as well.
> 
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
>  fs/proc/base.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 093ca14..3ece303 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -304,14 +304,17 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns,
>  }
>  #endif
>  
> +#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> +#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> +#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)

So such #ifdef parades are ugly and are usually a sign of some problem with the 
patch - as in this case.

But there's deeper problems as well:

/*
 * Provides /proc/PID/schedstat
 */
static int proc_pid_schedstat(struct seq_file *m, struct pid_namespace *ns,
                              struct pid *pid, struct task_struct *task)
{
        seq_printf(m, "%llu %llu %lu\n",
                   (unsigned long long)task->se.sum_exec_runtime,
                   (unsigned long long)task->sched_info.run_delay,
                   task->sched_info.pcount);

        return 0;
}

 - The sum_exec_runtime field is available unconditionally.

 - But the sched_info.run_delay field is only maintained if CONFIG_SCHEDSTATS is
   enabled.

 - Also, the sched_info.pcount field is again only maintained if CONFIG_SCHEDSTATS 
   is enabled.

So the claim in your changelog that these fields are maintained in the 
delayaccounting case is plain false: none of the fields are conditional on delay 
accounting.

So what's the purpose of your patch?

Thanks,

	Ingo