From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v9 09/12] ixgbe: enable rx queue interrupts
 for both PF and VF
Date: Fri, 29 May 2015 08:57:17 -0700
Message-ID: <20150529085717.106a770a@urahara>
References: <1432198563-16334-1-git-send-email-cunming.liang@intel.com>
 <1432889125-20255-1-git-send-email-cunming.liang@intel.com>
 <1432889125-20255-10-git-send-email-cunming.liang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, liang-min.wang@intel.com
To: Cunming Liang <cunming.liang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id B265A5A96
 for <dev@dpdk.org>; Fri, 29 May 2015 17:57:15 +0200 (CEST)
Received: by padbw4 with SMTP id bw4so63453845pad.0
 for <dev@dpdk.org>; Fri, 29 May 2015 08:57:15 -0700 (PDT)
In-Reply-To: <1432889125-20255-10-git-send-email-cunming.liang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 29 May 2015 16:45:22 +0800
Cunming Liang <cunming.liang@intel.com> wrote:

> +		if (intr_handle->intr_vec == NULL) {
> +			PMD_INIT_LOG(ERR, "Failed to allocate %d rx_queues"
> +				     "intr_vec\n", dev->data->nb_rx_queues);
> +			return -1;
> +		}
> +

Please return an actual error code (like -ENOMEM) rather than generic -1.
It allows for easier diagnosis when using API's.