All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Wangnan (F)" <wangnan0@huawei.com>,
	Namhyung Kim <namhyung@kernel.org>,
	lizefan@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: introduce arm64 support unwind test.
Date: Fri, 29 May 2015 16:40:24 +0200	[thread overview]
Message-ID: <20150529144024.GC14918@krava.brq.redhat.com> (raw)
In-Reply-To: <20150529133255.GS24859@kernel.org>

On Fri, May 29, 2015 at 10:32:55AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, May 29, 2015 at 11:21:19AM +0200, Jiri Olsa escreveu:
> > On Thu, May 28, 2015 at 10:43:14AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, May 28, 2015 at 03:17:26PM +0800, Wangnan (F) escreveu:
> > > > Ping?
> 
> > > Jiri, Ack?
>  
> > yep, I've already ack-ed that.. should be on the lkml somewhere ;-)
>  
> > > And from a quick look, isn't this better split in two pieces, i.e. the
> > > first wiring up ARM64 to libunwing, i.e. all those perf_regs.h files
> > > being added to tools/perf/arch/arm64/, and then a second patch, enabling
> > > the dwarf unwind 'perf test' entry to run on ARM64?
>  
> > I guess.. but the change is fairly small, so it did not occur
> > to me as necessary..
> 
> :-)
> 
> I felt mislead when looking at the subject, i.e. "hey, a new test,
> testing unwind on arm64", no, it wasn't that, it introduces support for
> unwind on ARM64 by providing that regs mapping, then it _enables_ an
> existing test on arm64 :-\

still it's good news right? ;-)

jirka

  reply	other threads:[~2015-05-29 14:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 13:08 [PATCH] perf tools: introduce arm64 support unwind test Wang Nan
2015-05-28  7:17 ` Wangnan (F)
2015-05-28 13:43   ` Arnaldo Carvalho de Melo
2015-05-29  9:21     ` Jiri Olsa
2015-05-29 13:32       ` Arnaldo Carvalho de Melo
2015-05-29 14:40         ` Jiri Olsa [this message]
2015-05-29 15:13           ` Arnaldo Carvalho de Melo
2015-05-29 18:36 ` [tip:perf/core] perf tools: Add ARM64 perf_regs_load to support libunwind and enable testing tip-bot for Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529144024.GC14918@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.