From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757886AbbEaCJq (ORCPT ); Sat, 30 May 2015 22:09:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39098 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbbEaCJh (ORCPT ); Sat, 30 May 2015 22:09:37 -0400 Date: Sun, 31 May 2015 10:36:52 +0900 From: Greg KH To: Pedro Marzo Perez Cc: navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init Message-ID: <20150531013652.GC28154@kroah.com> References: <1431991944-16924-1-git-send-email-marzo.pedro@gmail.com> <1431991944-16924-2-git-send-email-marzo.pedro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431991944-16924-2-git-send-email-marzo.pedro@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote: > Merge two pr_debug lines with literal strings splitted across several lines > into one single line, simplifying prism2_wep_init error check code. > > Signed-off-by: Pedro Marzo Perez > --- > .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > index 0a17f84..388ed3c 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > @@ -9,6 +9,8 @@ > * more details. > */ > > +#define pr_fmt(fmt) "ieee80211_crypt_wep: " fmt Like Dan said, don't do this in a driver. It's a driver, you almost always have access to the device being operated on, so use the dev_* functions. This is a network driver, so use the netdev_* functions, which are even better. But never the pr_* functions, that's not ok. Please fix up and resend. thanks, greg k-h