From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758415AbbEaPpw (ORCPT ); Sun, 31 May 2015 11:45:52 -0400 Received: from v1ros.org ([109.234.34.72]:59771 "EHLO smtp.v1ros.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754743AbbEaPpl convert rfc822-to-8bit (ORCPT ); Sun, 31 May 2015 11:45:41 -0400 X-Greylist: delayed 362 seconds by postgrey-1.27 at vger.kernel.org; Sun, 31 May 2015 11:45:41 EDT Date: Sun, 31 May 2015 18:37:40 +0300 From: Roman Volkov To: Dmitry Torokhov Cc: Mark Rutland , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "grant.likely@linaro.org" , Hans de Goede , Jiri Kosina , Wolfram Sang , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Tony Prisk Subject: Re: Message-ID: <20150531183740.17593bd3@v1ron-s7> In-Reply-To: References: X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org В Sat, 14 Mar 2015 20:20:38 -0700 Dmitry Torokhov wrote: > > Hi Roman, > > On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote: > > Documentation for 'intel,8042' DT compatible node. > > > > Signed-off-by: Tony Prisk > > Signed-off-by: Roman Volkov > > --- > > .../devicetree/bindings/input/intel-8042.txt | 26 > > ++++++++++++++++++++++ 1 file changed, 26 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/input/intel-8042.txt > > > > diff --git a/Documentation/devicetree/bindings/input/intel-8042.txt > > b/Documentation/devicetree/bindings/input/intel-8042.txt new file > > mode 100644 index 0000000..ab8a3e0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/intel-8042.txt > > @@ -0,0 +1,26 @@ > > +Intel 8042 Keyboard Controller > > + > > +Required properties: > > +- compatible: should be "intel,8042" > > +- regs: memory for keyboard controller > > +- interrupts: usually, two interrupts should be specified > > (keyboard and aux). > > + However, only one interrupt is also allowed in case of > > absence of the > > + physical port in the controller. The i8042 driver must be > > loaded with > > + nokbd/noaux option in this case. > > +- interrupt-names: interrupt names corresponding to numbers in the > > list. > > + "kbd" is the keyboard interrupt and "aux" is the auxiliary > > (mouse) > > + interrupt. > > +- command-reg: offset in memory for command register > > +- status-reg: offset in memory for status register > > +- data-reg: offset in memory for data register > > + > > +Example: > > + i8042@d8008800 { > > + compatible = "intel,8042"; > > + regs = <0xd8008800 0x100>; > > + interrupts = <23>, <4>; > > + interrupt-names = "kbd", "aux"; > > + command-reg = <0x04>; > > + status-reg = <0x04>; > > + data-reg = <0x00>; > > + }; > > No, we already have existing OF bindings for i8042 on sparc and > powerpc, I do not think we need to invent a brand new one. > > Thanks. > Hi Dmitry, I see some OF code in i8042-sparcio.h file. There are node definitions like "kb_ps2", "keyboard", "kdmouse", "mouse". Are these documented somewhere? Great if vt8500 is not unique with OF bindings for i8042. The code from sparc even looks compatible, only register offsets are hardcoded for specific machine. Is it possible to read offsets from Device Tree using these existing bindings without dealing with the kernel configuration? Regards, Roman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Volkov Subject: Re: Date: Sun, 31 May 2015 18:37:40 +0300 Message-ID: <20150531183740.17593bd3@v1ron-s7> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-input-owner@vger.kernel.org To: Dmitry Torokhov Cc: Mark Rutland , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "grant.likely@linaro.org" , Hans de Goede , Jiri Kosina , Wolfram Sang , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Tony Prisk List-Id: devicetree@vger.kernel.org =D0=92 Sat, 14 Mar 2015 20:20:38 -0700 Dmitry Torokhov wrote: >=20 > Hi Roman, >=20 > On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote: > > Documentation for 'intel,8042' DT compatible node. > >=20 > > Signed-off-by: Tony Prisk > > Signed-off-by: Roman Volkov > > --- > > .../devicetree/bindings/input/intel-8042.txt | 26 > > ++++++++++++++++++++++ 1 file changed, 26 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/input/intel-8042.txt > >=20 > > diff --git a/Documentation/devicetree/bindings/input/intel-8042.txt > > b/Documentation/devicetree/bindings/input/intel-8042.txt new file > > mode 100644 index 0000000..ab8a3e0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/intel-8042.txt > > @@ -0,0 +1,26 @@ > > +Intel 8042 Keyboard Controller > > + > > +Required properties: > > +- compatible: should be "intel,8042" > > +- regs: memory for keyboard controller > > +- interrupts: usually, two interrupts should be specified > > (keyboard and aux). > > + However, only one interrupt is also allowed in case of > > absence of the > > + physical port in the controller. The i8042 driver must be > > loaded with > > + nokbd/noaux option in this case. > > +- interrupt-names: interrupt names corresponding to numbers in the > > list. > > + "kbd" is the keyboard interrupt and "aux" is the auxiliary > > (mouse) > > + interrupt. > > +- command-reg: offset in memory for command register > > +- status-reg: offset in memory for status register > > +- data-reg: offset in memory for data register > > + > > +Example: > > + i8042@d8008800 { > > + compatible =3D "intel,8042"; > > + regs =3D <0xd8008800 0x100>; > > + interrupts =3D <23>, <4>; > > + interrupt-names =3D "kbd", "aux"; > > + command-reg =3D <0x04>; > > + status-reg =3D <0x04>; > > + data-reg =3D <0x00>; > > + }; >=20 > No, we already have existing OF bindings for i8042 on sparc and > powerpc, I do not think we need to invent a brand new one. >=20 > Thanks. >=20 Hi Dmitry, I see some OF code in i8042-sparcio.h file. There are node definitions like "kb_ps2", "keyboard", "kdmouse", "mouse". Are these documented somewhere? Great if vt8500 is not unique with OF bindings for i8042. The code from sparc even looks compatible, only register offsets are hardcoded for specific machine. Is it possible to read offsets from Device Tree using these existing bindings without dealing with the kernel configuration? Regards, Roman -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html