From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v9 12/12] abi: fix v2.1 abi broken issue Date: Mon, 1 Jun 2015 07:11:12 -0700 Message-ID: <20150601071112.32e26604@urahara> References: <1432198563-16334-1-git-send-email-cunming.liang@intel.com> <1432889125-20255-1-git-send-email-cunming.liang@intel.com> <1432889125-20255-13-git-send-email-cunming.liang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, liang-min.wang@intel.com To: Cunming Liang Return-path: Received: from mx0b-000f0801.pphosted.com (mx0b-000f0801.pphosted.com [67.231.152.113]) by dpdk.org (Postfix) with ESMTP id 00DBA58C3 for ; Mon, 1 Jun 2015 16:11:24 +0200 (CEST) In-Reply-To: <1432889125-20255-13-git-send-email-cunming.liang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 29 May 2015 16:45:25 +0800 Cunming Liang wrote: > RTE_EAL_RX_INTR will be removed from v2.2. It's only used to avoid ABI(unannounced) broken in v2.1. > The usrs should make sure understand the impact before turning on the feature. > There are two abi changes required in this interrupt patch set. > They're 1) struct rte_intr_handle; 2) struct rte_intr_conf. > > Signed-off-by: Cunming Liang > --- While merging for testing I discovered another minor issue. The patch order here is a problem. The intermediate steps won't build until this last patch is applied. In order to allow git bisect to be useful, it is important that every commit done in the upstream version build and work. This series does not seem to build until this last patch is applied. Maybe it should just be first?